chrome/app/chromium_strings.grd - Issue 2252063002: Adding client code for new desktop First Run Experience.

Side by Side Diff: chrome/app/chromium_strings.grd

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing build issues after rebasing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!-- This file contains definitions of strings that are distribution specific.	2 <!-- This file contains definitions of strings that are distribution specific.

3 If you update this file, be sure also to update google_chrome_strings.grd. -->	3 If you update this file, be sure also to update google_chrome_strings.grd. -->

4	4

5 <grit base_dir="." latest_public_release="0" current_release="1"	5 <grit base_dir="." latest_public_release="0" current_release="1"

6 output_all_resource_defines="false" source_lang_id="en" enc_check="möl">	6 output_all_resource_defines="false" source_lang_id="en" enc_check="möl">

7 <outputs>	7 <outputs>

8 <output filename="grit/chromium_strings.h" type="rc_header">	8 <output filename="grit/chromium_strings.h" type="rc_header">

9 <emit emit_type='prepend'></emit>	9 <emit emit_type='prepend'></emit>

10 </output>	10 </output>

(...skipping 1243 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1254 <message name="IDS_METRO_FLOW_TITLE_SHORT"	1254 <message name="IDS_METRO_FLOW_TITLE_SHORT"

1255 desc="The title at the top of the window guiding user through m aking Chrome default in Metro.">	1255 desc="The title at the top of the window guiding user through m aking Chrome default in Metro.">

1256 Chromium is almost ready.	1256 Chromium is almost ready.

1257 </message>	1257 </message>

1258 <message name="IDS_METRO_FLOW_LOGO_STRING_ALT"	1258 <message name="IDS_METRO_FLOW_LOGO_STRING_ALT"

1259 desc="Alt text for the faded Chrome logo image.">	1259 desc="Alt text for the faded Chrome logo image.">

1260 Chromium logo	1260 Chromium logo

1261 </message>	1261 </message>

1262 </if>	1262 </if>

1263	1263

	1264 <!-- Welcome page (chrome://welcome) strings -->
	michaelpg 2016/09/06 22:21:56 all resources in this CL: wrap in <if expr="not ch all resources in this CL: wrap in <if expr="not chromeos"> tmartino 2016/09/07 23:06:42 Done Show quoted text On 2016/09/06 at 22:21:56, michaelpg wrote: > all resources in this CL: wrap in <if expr="not chromeos"> Done
	1265 <message name="IDS_WELCOME_UI_WELCOME_HEADER" desc="A message which will a ppear as the header on the Welcome UI if the user has never run Chromium before. ">
	michaelpg 2016/09/06 22:21:56 <bikeshed> We almost never use "_UI_" in string n <bikeshed> We almost never use "_UI_" in string name. Since this is the same header (just different context for different situations) I would name them with the same prefixes, e.g.: IDS_WELCOME_HEADER IDS_WELCOME_HEADER_AFTER_FIRST_RUN </bikeshed> tmartino 2016/09/07 23:06:42 Done Show quoted text On 2016/09/06 at 22:21:56, michaelpg wrote: > <bikeshed> > > We almost never use "_UI_" in string name. > > Since this is the same header (just different context for different situations) I would name them with the same prefixes, e.g.: > > IDS_WELCOME_HEADER > IDS_WELCOME_HEADER_AFTER_FIRST_RUN > > </bikeshed> Done
	1266 Welcome to Chromium

	1267 </message>

	1268 <message name="IDS_WELCOME_UI_EVERYWHERE_HEADER" desc="A message which wil l appear as the header on the Welcome UI if the user has run Chromium before.">

	1269 Take Chromium everywhere

	1270 </message>

	1271

1264 </messages>	1272 </messages>

1265 </release>	1273 </release>

1266 </grit>	1274 </grit>

OLD	NEW

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/browser/resources/welcome/welcome.html » ('J')