Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2252053002: Add pretty-printing for PasswordStore::FormDigest (Closed)

Created:
4 years, 4 months ago by vabr (Chromium)
Modified:
4 years, 4 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pretty-printing for PasswordStore::FormDigest This helps when printing FormDigest objects to logs during debugging. autofill::PasswordForm has a similar operator but implemented through JSON stringification for better flexibility. FormDigest does not need this, because it only has 3 members and is unlikely to grow. R=dvadym@chromium.org BUG=621355 Committed: https://crrev.com/71252e6d95d5660cde315afeaf23cbe91c42c046 Cr-Commit-Position: refs/heads/master@{#412595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M components/password_manager/core/browser/password_store.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
vabr (Chromium)
Hi Vadym, Could you PTAL? Thanks! Vaclav
4 years, 4 months ago (2016-08-17 14:52:56 UTC) #3
dvadym
On 2016/08/17 14:52:56, vabr (Chromium) wrote: > Hi Vadym, > > Could you PTAL? > ...
4 years, 4 months ago (2016-08-17 16:33:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252053002/1
4 years, 4 months ago (2016-08-17 18:34:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 18:39:46 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:43:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71252e6d95d5660cde315afeaf23cbe91c42c046
Cr-Commit-Position: refs/heads/master@{#412595}

Powered by Google App Engine
This is Rietveld 408576698