ui/gfx/render_text_mac.h - Issue 2251893004: Use parameterized tests to test multiple render text implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_mac.h

Issue 2251893004: Use parameterized tests to test multiple render text implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection_direction

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_mac.h

diff --git a/ui/gfx/render_text_mac.h b/ui/gfx/render_text_mac.h

index a437ac57982d140797fa35616c3d5d30389bf81a..7c1d67e9314adb3941cb2c0177faccf4c10b4f88 100644

--- a/ui/gfx/render_text_mac.h

+++ b/ui/gfx/render_text_mac.h

@@ -60,7 +60,7 @@ class GFX_EXPORT RenderTextMac : public RenderText {

void DrawVisualText(internal::SkiaTextRenderer* renderer) override;

private:

- FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Mac_ElidedText);

+ FRIEND_TEST_ALL_PREFIXES(RenderTextMacTest, Mac_ElidedText);

struct TextRun {

CTRunRef ct_run;

« no previous file with comments | « ui/gfx/render_text_harfbuzz.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »