ui/gfx/render_text_harfbuzz.cc - Issue 2251893004: Use parameterized tests to test multiple render text implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2251893004: Use parameterized tests to test multiple render text implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection_direction

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index ebc72a47fdfc9d2c64cba528fb8352ee2dcfd677..d0b3dd7200278cbaadb91c086ddda01ec5a6638b 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -474,7 +474,7 @@ class HarfBuzzLineBreaker {

// |max_width_| might be smaller than a single character. In this case we

// need to put at least one character in the line. Note that, we should

// not separate surrogate pair or combining characters.

- // See RenderTextTest.Multiline_MinWidth for an example.

+ // See RenderTextHarfBuzzTest.Multiline_MinWidth for an example.

if (width == 0 && available_width_ == max_width_) {

end_pos = std::min(

segment.char_range.end(),

« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »