Add window property for restore bounds when virtual keyboard is enabled.

Add window property for restore bounds when virtual keyboard is enabled.

Added the kVirtualKeyboardNewBoundsKey aura::Window property which 
stores the restore bounds of the window when it is moved by the virtual 
keyboard. Required for future changes to virtual keyboard behavior. Also 
added a method to access Rect window properties from WmWindow through 
WmWindowAura.

BUG=624521

[hariank, 2016-08-16 21:07:54]

Description was changed from

==========
Add window properties for changed bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property and the VK_NEW_BOUNDS
WmWindowProperty which store the shifted bounds of the window when it is
moved by the virtual keyboard. Required for future changes to virtual
keyboard behavior.

BUG=624521
==========

to

==========
Add window properties for changed bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property and the VK_NEW_BOUNDS
WmWindowProperty which store the shifted bounds of the window when it is
moved by the virtual keyboard. Required for future changes to virtual
keyboard behavior.

BUG=624521
==========

[hariank, 2016-08-16 21:07:54]

hariank@google.com changed reviewers:
+ oshima@chromium.org, sky@chromium.org

[hariank, 2016-08-16 21:08:58]

Please review my CL. Note that this is a precursor CL for new virtual keyboard
behavior, described in
https://docs.google.com/a/google.com/document/d/1hMVJC1qdCrkTmrfC8puKu8SbSK-w....

[hariank, 2016-08-16 21:20:37]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-08-16 22:58:11]

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
File ui/aura/client/aura_constants.h (right):

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
We need some way to pass bounds information from renderer host to ash, but this
may not be the good place for it. sky@, do you have any suggestion?

[commit-bot: I haz the power, 2016-08-16 22:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:59:58]

Dry run: Exceeded global retry quota

[oshima, 2016-08-16 23:14:02]

https://codereview.chromium.org/2251843002/diff/1/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2251843002/diff/1/ash/common/wm_window.h#newc...
ash/common/wm_window.h:16: #include "ui/gfx/geometry/rect.h"
use forward declaration.

https://codereview.chromium.org/2251843002/diff/1/ash/mus/bridge/wm_window_mu...
File ash/mus/bridge/wm_window_mus.cc (right):

https://codereview.chromium.org/2251843002/diff/1/ash/mus/bridge/wm_window_mu...
ash/mus/bridge/wm_window_mus.cc:370: gfx::Rect*
WmWindowMus::GetRectProperty(WmWindowProperty key) {
NOTIMPLEMENTED(); 

Please file a bug like below.

https://codereview.chromium.org/2251843002/diff/1/ash/wm/window_util_unittest.cc
File ash/wm/window_util_unittest.cc (right):

https://codereview.chromium.org/2251843002/diff/1/ash/wm/window_util_unittest...
ash/wm/window_util_unittest.cc:100: UpdateDisplay("500x400, 600x400");
This will not work on windows. Do you need this?

[hariank, 2016-08-16 23:35:06]

https://codereview.chromium.org/2251843002/diff/1/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2251843002/diff/1/ash/common/wm_window.h#newc...
ash/common/wm_window.h:16: #include "ui/gfx/geometry/rect.h"
On 2016/08/16 23:14:02, oshima wrote:
> use forward declaration.

Done.

https://codereview.chromium.org/2251843002/diff/1/ash/mus/bridge/wm_window_mu...
File ash/mus/bridge/wm_window_mus.cc (right):

https://codereview.chromium.org/2251843002/diff/1/ash/mus/bridge/wm_window_mu...
ash/mus/bridge/wm_window_mus.cc:370: gfx::Rect*
WmWindowMus::GetRectProperty(WmWindowProperty key) {
On 2016/08/16 23:14:02, oshima wrote:
> NOTIMPLEMENTED(); 
> 
> Please file a bug like below.

Done.

https://codereview.chromium.org/2251843002/diff/1/ash/wm/window_util_unittest.cc
File ash/wm/window_util_unittest.cc (right):

https://codereview.chromium.org/2251843002/diff/1/ash/wm/window_util_unittest...
ash/wm/window_util_unittest.cc:100: UpdateDisplay("500x400, 600x400");
On 2016/08/16 23:14:02, oshima wrote:
> This will not work on windows. Do you need this?

Done.

[hariank, 2016-08-16 23:35:12]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:35:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-16 23:37:19]

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
File ui/aura/client/aura_constants.h (right):

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
On 2016/08/16 22:58:11, oshima wrote:
> We need some way to pass bounds information from renderer host to ash, but
this
> may not be the good place for it. sky@, do you have any suggestion?

Good question. Can you elaborate more on what the interaction between the two
will be? From the description here it seems like the renderer should call
SetBounds(), but no doubt I'm missing something.

[commit-bot: I haz the power, 2016-08-17 00:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:18:21]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-17 00:57:05]

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
File ui/aura/client/aura_constants.h (right):

https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
On 2016/08/16 23:37:19, sky wrote:
> On 2016/08/16 22:58:11, oshima wrote:
> > We need some way to pass bounds information from renderer host to ash, but
> this
> > may not be the good place for it. sky@, do you have any suggestion?
> 
> Good question. Can you elaborate more on what the interaction between the two
> will be? From the description here it seems like the renderer should call
> SetBounds(), but no doubt I'm missing something.

So the goal is to be able to restore when VK is hidden, or the window is
unfocused.
That event can happen in both views and contents, and the original bounds needs
to be
shared between them.

We had offline discussion and we can do that without WmWindow change (jamescook@
told me that
it'll be needed so we can land it separately if that's still useful), but
we still need some way to share the bounds between then for the window.

[sky, 2016-08-17 15:11:50]

https://codereview.chromium.org/2251843002/diff/20001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2251843002/diff/20001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:311: return new gfx::Rect();
This leaks. Can you return null?

[sky, 2016-08-17 15:14:05]

On Tue, Aug 16, 2016 at 5:57 PM,  <oshima@chromium.org> wrote:
>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> File ui/aura/client/aura_constants.h (right):
>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
> WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
> On 2016/08/16 23:37:19, sky wrote:
>> On 2016/08/16 22:58:11, oshima wrote:
>> > We need some way to pass bounds information from renderer host to
> ash, but
>> this
>> > may not be the good place for it. sky@, do you have any suggestion?
>>
>> Good question. Can you elaborate more on what the interaction between
> the two
>> will be? From the description here it seems like the renderer should
> call
>> SetBounds(), but no doubt I'm missing something.
>
> So the goal is to be able to restore when VK is hidden, or the window is
> unfocused.
> That event can happen in both views and contents, and the original
> bounds needs to be
> shared between them.

Who is positioning the windows when the VK comes up? Can the VK itself
take care of all this? By that I mean can the VK remember the bounds
it wants to restore to and handle setting to the bounds under the
necessary conditions?

  -Scott

> We had offline discussion and we can do that without WmWindow change
> (jamescook@ told me that
> it'll be needed so we can land it separately if that's still useful),
> but
> we still need some way to share the bounds between then for the window.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hariank, 2016-08-17 17:55:15]

On 2016/08/17 15:14:05, sky wrote:
> On Tue, Aug 16, 2016 at 5:57 PM,  <mailto:oshima@chromium.org> wrote:
> >
> >
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> > File ui/aura/client/aura_constants.h (right):
> >
> >
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> > ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
> > WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
> > On 2016/08/16 23:37:19, sky wrote:
> >> On 2016/08/16 22:58:11, oshima wrote:
> >> > We need some way to pass bounds information from renderer host to
> > ash, but
> >> this
> >> > may not be the good place for it. sky@, do you have any suggestion?
> >>
> >> Good question. Can you elaborate more on what the interaction between
> > the two
> >> will be? From the description here it seems like the renderer should
> > call
> >> SetBounds(), but no doubt I'm missing something.
> >
> > So the goal is to be able to restore when VK is hidden, or the window is
> > unfocused.
> > That event can happen in both views and contents, and the original
> > bounds needs to be
> > shared between them.
> 
> Who is positioning the windows when the VK comes up? Can the VK itself
> take care of all this? By that I mean can the VK remember the bounds
> it wants to restore to and handle setting to the bounds under the
> necessary conditions?
> 
>   -Scott
> 
> > We had offline discussion and we can do that without WmWindow change
> > (jamescook@ told me that
> > it'll be needed so we can land it separately if that's still useful),
> > but
> > we still need some way to share the bounds between then for the window.
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

With the new VK behavior, the VK informs the TextInputClient that it has been
opened or closed. The TextInputClient then calls EnsureCaretInRect on the window
to be positioned when focused. The VK itself cannot do this, because the method
by which the window is positioned is dependent on the client -
RenderWidgetHostViewAura's EnsureCaretInRect includes overscroll as well as
moving the window, while TextField's EnsureCaretInRect just moves the window.
EnsureCaretInRect sets a window property, which is propagated through to
WindowState through OnWindowPropertyChanged. WindowState then does the final
move/restore. All of this will be in a future CL. 
One option to remove the dependence on the WMWindowProperty is to do the
moving/restoring in EnsureCaretInRect. Then restore bounds can be saved in a
WindowProperty and all the changes to WmWindow, WmWindowAura, and WindowState
won't be necessary. Would that be a better option?

[sky, 2016-08-17 19:34:48]

Where is the override for EnsureCaretInRect that does the move?

  -Scott

On Wed, Aug 17, 2016 at 10:55 AM, hariank via Chromium-reviews
<chromium-reviews@chromium.org> wrote:
> On 2016/08/17 15:14:05, sky wrote:
>
>> On Tue, Aug 16, 2016 at 5:57 PM, <mailto:oshima@chromium.org> wrote:
>> >
>> >
>>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
>> > File ui/aura/client/aura_constants.h (right):
>> >
>> >
>>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
>> > ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
>> > WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
>> > On 2016/08/16 23:37:19, sky wrote:
>> >> On 2016/08/16 22:58:11, oshima wrote:
>> >> > We need some way to pass bounds information from renderer host to
>> > ash, but
>> >> this
>> >> > may not be the good place for it. sky@, do you have any suggestion?
>> >>
>> >> Good question. Can you elaborate more on what the interaction between
>> > the two
>> >> will be? From the description here it seems like the renderer should
>> > call
>> >> SetBounds(), but no doubt I'm missing something.
>> >
>> > So the goal is to be able to restore when VK is hidden, or the window is
>> > unfocused.
>> > That event can happen in both views and contents, and the original
>> > bounds needs to be
>> > shared between them.
>>
>> Who is positioning the windows when the VK comes up? Can the VK itself
>> take care of all this? By that I mean can the VK remember the bounds
>> it wants to restore to and handle setting to the bounds under the
>> necessary conditions?
>>
>> -Scott
>>
>> > We had offline discussion and we can do that without WmWindow change
>> > (jamescook@ told me that
>> > it'll be needed so we can land it separately if that's still useful),
>> > but
>> > we still need some way to share the bounds between then for the window.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Chromium-reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
> email
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> With the new VK behavior, the VK informs the TextInputClient that it has
> been
> opened or closed. The TextInputClient then calls EnsureCaretInRect on the
> window
> to be positioned when focused. The VK itself cannot do this, because the
> method
> by which the window is positioned is dependent on the client -
> RenderWidgetHostViewAura's EnsureCaretInRect includes overscroll as well as
> moving the window, while TextField's EnsureCaretInRect just moves the
> window.
> EnsureCaretInRect sets a window property, which is propagated through to
> WindowState through OnWindowPropertyChanged. WindowState then does the final
> move/restore. All of this will be in a future CL.
> One option to remove the dependence on the WMWindowProperty is to do the
> moving/restoring in EnsureCaretInRect. Then restore bounds can be saved in a
> WindowProperty and all the changes to WmWindow, WmWindowAura, and
> WindowState
> won't be necessary. Would that be a better option?
>
> https://codereview.chromium.org/2251843002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hariank, 2016-08-17 22:53:46]

On 2016/08/17 19:34:48, sky wrote:
> Where is the override for EnsureCaretInRect that does the move?
> 
>   -Scott
> 
> On Wed, Aug 17, 2016 at 10:55 AM, hariank via Chromium-reviews
> <mailto:chromium-reviews@chromium.org> wrote:
> > On 2016/08/17 15:14:05, sky wrote:
> >
> >> On Tue, Aug 16, 2016 at 5:57 PM, <mailto:oshima@chromium.org> wrote:
> >> >
> >> >
> >>
> >
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> >> > File ui/aura/client/aura_constants.h (right):
> >> >
> >> >
> >>
> >
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
> >> > ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
> >> > WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
> >> > On 2016/08/16 23:37:19, sky wrote:
> >> >> On 2016/08/16 22:58:11, oshima wrote:
> >> >> > We need some way to pass bounds information from renderer host to
> >> > ash, but
> >> >> this
> >> >> > may not be the good place for it. sky@, do you have any suggestion?
> >> >>
> >> >> Good question. Can you elaborate more on what the interaction between
> >> > the two
> >> >> will be? From the description here it seems like the renderer should
> >> > call
> >> >> SetBounds(), but no doubt I'm missing something.
> >> >
> >> > So the goal is to be able to restore when VK is hidden, or the window is
> >> > unfocused.
> >> > That event can happen in both views and contents, and the original
> >> > bounds needs to be
> >> > shared between them.
> >>
> >> Who is positioning the windows when the VK comes up? Can the VK itself
> >> take care of all this? By that I mean can the VK remember the bounds
> >> it wants to restore to and handle setting to the bounds under the
> >> necessary conditions?
> >>
> >> -Scott
> >>
> >> > We had offline discussion and we can do that without WmWindow change
> >> > (jamescook@ told me that
> >> > it'll be needed so we can land it separately if that's still useful),
> >> > but
> >> > we still need some way to share the bounds between then for the window.
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "Chromium-reviews" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an
> > email
> >> to mailto:chromium-reviews+unsubscribe@chromium.org.
> >>
> >
> > With the new VK behavior, the VK informs the TextInputClient that it has
> > been
> > opened or closed. The TextInputClient then calls EnsureCaretInRect on the
> > window
> > to be positioned when focused. The VK itself cannot do this, because the
> > method
> > by which the window is positioned is dependent on the client -
> > RenderWidgetHostViewAura's EnsureCaretInRect includes overscroll as well as
> > moving the window, while TextField's EnsureCaretInRect just moves the
> > window.
> > EnsureCaretInRect sets a window property, which is propagated through to
> > WindowState through OnWindowPropertyChanged. WindowState then does the final
> > move/restore. All of this will be in a future CL.
> > One option to remove the dependence on the WMWindowProperty is to do the
> > moving/restoring in EnsureCaretInRect. Then restore bounds can be saved in a
> > WindowProperty and all the changes to WmWindow, WmWindowAura, and
> > WindowState
> > won't be necessary. Would that be a better option?
> >
> > https://codereview.chromium.org/2251843002/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

You can see a preliminary version of it in
https://codereview.chromium.org/2240353002. The EnsureCaretInRect overrides are
in render_widget_host_view_aura.cc and textfield.cc.

[sky, 2016-08-17 23:38:19]

I briefly looked at https://codereview.chromium.org/2240353002 .
AFAICT WindowState doesn't really do anything with the vkbounds. Is
there a reason we need to route the change through WindowState rather
than having RWHVA call SetBounds directly?

On Wed, Aug 17, 2016 at 3:53 PM,  <hariank@google.com> wrote:
> On 2016/08/17 19:34:48, sky wrote:
>> Where is the override for EnsureCaretInRect that does the move?
>>
>> -Scott
>>
>> On Wed, Aug 17, 2016 at 10:55 AM, hariank via Chromium-reviews
>> <mailto:chromium-reviews@chromium.org> wrote:
>> > On 2016/08/17 15:14:05, sky wrote:
>> >
>> >> On Tue, Aug 16, 2016 at 5:57 PM, <mailto:oshima@chromium.org> wrote:
>> >> >
>> >> >
>> >>
>> >
>>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
>> >> > File ui/aura/client/aura_constants.h (right):
>> >> >
>> >> >
>> >>
>> >
>>
>
https://codereview.chromium.org/2251843002/diff/1/ui/aura/client/aura_constan...
>> >> > ui/aura/client/aura_constants.h:60: AURA_EXPORT extern const
>> >> > WindowProperty<gfx::Rect*>* const kVKNewBoundsKey;
>> >> > On 2016/08/16 23:37:19, sky wrote:
>> >> >> On 2016/08/16 22:58:11, oshima wrote:
>> >> >> > We need some way to pass bounds information from renderer host to
>> >> > ash, but
>> >> >> this
>> >> >> > may not be the good place for it. sky@, do you have any
>> >> >> > suggestion?
>> >> >>
>> >> >> Good question. Can you elaborate more on what the interaction
>> >> >> between
>> >> > the two
>> >> >> will be? From the description here it seems like the renderer should
>> >> > call
>> >> >> SetBounds(), but no doubt I'm missing something.
>> >> >
>> >> > So the goal is to be able to restore when VK is hidden, or the window
>> >> > is
>> >> > unfocused.
>> >> > That event can happen in both views and contents, and the original
>> >> > bounds needs to be
>> >> > shared between them.
>> >>
>> >> Who is positioning the windows when the VK comes up? Can the VK itself
>> >> take care of all this? By that I mean can the VK remember the bounds
>> >> it wants to restore to and handle setting to the bounds under the
>> >> necessary conditions?
>> >>
>> >> -Scott
>> >>
>> >> > We had offline discussion and we can do that without WmWindow change
>> >> > (jamescook@ told me that
>> >> > it'll be needed so we can land it separately if that's still useful),
>> >> > but
>> >> > we still need some way to share the bounds between then for the
>> >> > window.
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google
>> >> Groups
>> >> "Chromium-reviews" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send
>> >> an
>> > email
>> >> to mailto:chromium-reviews+unsubscribe@chromium.org.
>> >>
>> >
>> > With the new VK behavior, the VK informs the TextInputClient that it has
>> > been
>> > opened or closed. The TextInputClient then calls EnsureCaretInRect on
>> > the
>> > window
>> > to be positioned when focused. The VK itself cannot do this, because the
>> > method
>> > by which the window is positioned is dependent on the client -
>> > RenderWidgetHostViewAura's EnsureCaretInRect includes overscroll as well
>> > as
>> > moving the window, while TextField's EnsureCaretInRect just moves the
>> > window.
>> > EnsureCaretInRect sets a window property, which is propagated through to
>> > WindowState through OnWindowPropertyChanged. WindowState then does the
>> > final
>> > move/restore. All of this will be in a future CL.
>> > One option to remove the dependence on the WMWindowProperty is to do the
>> > moving/restoring in EnsureCaretInRect. Then restore bounds can be saved
>> > in a
>> > WindowProperty and all the changes to WmWindow, WmWindowAura, and
>> > WindowState
>> > won't be necessary. Would that be a better option?
>> >
>> > https://codereview.chromium.org/2251843002/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Chromium-reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
> email
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> You can see a preliminary version of it in
> https://codereview.chromium.org/2240353002. The EnsureCaretInRect overrides
> are
> in render_widget_host_view_aura.cc and textfield.cc.
>
> https://codereview.chromium.org/2251843002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hariank, 2016-08-18 00:35:36]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hariank, 2016-08-18 00:36:25]

Description was changed from

==========
Add window properties for changed bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property and the VK_NEW_BOUNDS
WmWindowProperty which store the shifted bounds of the window when it is
moved by the virtual keyboard. Required for future changes to virtual
keyboard behavior.

BUG=624521
==========

to

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore bounds
of the window when it is moved by the virtual keyboard. Required for future
changes to virtual
keyboard behavior.

BUG=624521
==========

[hariank, 2016-08-18 00:41:41]

Description was changed from

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore bounds
of the window when it is moved by the virtual keyboard. Required for future
changes to virtual
keyboard behavior.

BUG=624521
==========

to

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore
bounds of the window when it is moved by the virtual keyboard. Required
for future changes to virtual keyboard behavior.

BUG=624521
==========

[hariank, 2016-08-18 00:50:37]

Description was changed from

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore
bounds of the window when it is moved by the virtual keyboard. Required
for future changes to virtual keyboard behavior.

BUG=624521
==========

to

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore
bounds of the window when it is moved by the virtual keyboard. Required
for future changes to virtual keyboard behavior. Also added a 
method to access Rect window properties from WmWindow through 
WmWindowAura.

BUG=624521
==========

[hariank, 2016-08-18 00:51:56]

Description was changed from

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVKNewBoundsKey aura::Window property which stores the restore
bounds of the window when it is moved by the virtual keyboard. Required
for future changes to virtual keyboard behavior. Also added a 
method to access Rect window properties from WmWindow through 
WmWindowAura.

BUG=624521
==========

to

==========
Add window property for restore bounds when virtual keyboard is enabled.

Added the kVirtualKeyboardNewBoundsKey aura::Window property which 
stores the restore bounds of the window when it is moved by the virtual 
keyboard. Required for future changes to virtual keyboard behavior. Also 
added a method to access Rect window properties from WmWindow through 
WmWindowAura.

BUG=624521
==========

[commit-bot: I haz the power, 2016-08-18 01:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:43:54]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-18 22:52:17]

https://codereview.chromium.org/2251843002/diff/40001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2251843002/diff/40001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:307: return new gfx::Rect();
How come you're not getting the property from the window?