Move feedback files into src/components

components/feedback.gypi

Index: components/feedback.gypi
diff --git a/components/feedback.gypi b/components/feedback.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..5a9ced38b7e1286fb4c8f02e6004a0d4f94cc797
--- /dev/null
+++ b/components/feedback.gypi
@@ -0,0 +1,75 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'feedback_component',
+      'type': 'static_library',
+      'dependencies': [
+        '../base/base.gyp:base',
+        'feedback_internal',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'defines': [
+      ],
+      'sources': [
+        'feedback/common/feedback_switches.cc',

[jochen (gone - plz use gerrit), 2014/04/23 08:21:24]

unless you need to depend on those files from e.g. chrome/common I wouldn't put
those into a separate sub directory.

[achaulk, 2014/04/23 14:51:32]

Done.

+        'feedback/common/feedback_switches.h',
+        'feedback/feedback_uploader_chrome.cc',
+        'feedback/feedback_uploader_chrome.h',
+        'feedback/feedback_uploader_delegate.cc',
+        'feedback/feedback_uploader_delegate.h',
+        'feedback/feedback_uploader_factory.cc',
+        'feedback/feedback_uploader_factory.h',
+        'feedback/tracing_manager.cc',
+        'feedback/tracing_manager.h',
+      ],
+    },
+    {
+      'target_name': 'feedback_internal',

[jochen (gone - plz use gerrit), 2014/04/23 08:21:24]

what's the reason to introduce two targets?

[achaulk, 2014/04/23 14:51:32]

It used to be the unittest code wouldn't compile with the other file, but with
the cleaned up deps these should be mergeable

On 2014/04/23 08:21:24, jochen wrote:

+      'type': 'static_library',
+      'dependencies': [
+        '../base/base.gyp:base',
+        'feedback_proto',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'defines': [
+      ],
+      'sources': [
+        'feedback/feedback_data.cc',
+        'feedback/feedback_data.h',
+        'feedback/feedback_report.cc',
+        'feedback/feedback_report.h',
+        'feedback/feedback_uploader.cc',
+        'feedback/feedback_uploader.h',
+        'feedback/feedback_util.cc',
+        'feedback/feedback_util.h',
+      ],
+    },
+    {
+      # Protobuf compiler / generate rule for feedback
+      'target_name': 'feedback_proto',
+      'type': 'static_library',
+      'sources': [
+        'feedback/proto/annotations.proto',
+        'feedback/proto/chrome.proto',
+        'feedback/proto/common.proto',
+        'feedback/proto/dom.proto',
+        'feedback/proto/extension.proto',
+        'feedback/proto/math.proto',
+        'feedback/proto/web.proto',
+      ],
+      'variables': {
+        'proto_in_dir': 'feedback/proto',
+        'proto_out_dir': 'components/feedback/proto',
+      },
+      'includes': [ '../build/protoc.gypi' ]
+    },
+  ],
+}