Chromium Code Reviews Chromium Code Reviews
Issue 225183018:
Move feedback files into src/components (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 { | |
| 6 'targets': [ | |
| 7 { | |
| 8 'target_name': 'feedback_component', | |
| 9 'type': 'static_library', | |
| 10 'dependencies': [ | |
| 11 '../base/base.gyp:base', | |
| 12 'feedback_internal', | |
| 13 ], | |
| 14 'include_dirs': [ | |
| 15 '..', | |
| 16 ], | |
| 17 'defines': [ | |
| 18 ], | |
| 19 'sources': [ | |
| 20 'feedback/common/feedback_switches.cc', | |
|
jochen (gone - plz use gerrit)
2014/04/23 08:21:24
unless you need to depend on those files from e.g.
achaulk
2014/04/23 14:51:32
Done.
| |
| 21 'feedback/common/feedback_switches.h', | |
| 22 'feedback/feedback_uploader_chrome.cc', | |
| 23 'feedback/feedback_uploader_chrome.h', | |
| 24 'feedback/feedback_uploader_delegate.cc', | |
| 25 'feedback/feedback_uploader_delegate.h', | |
| 26 'feedback/feedback_uploader_factory.cc', | |
| 27 'feedback/feedback_uploader_factory.h', | |
| 28 'feedback/tracing_manager.cc', | |
| 29 'feedback/tracing_manager.h', | |
| 30 ], | |
| 31 }, | |
| 32 { | |
| 33 'target_name': 'feedback_internal', | |
|
jochen (gone - plz use gerrit)
2014/04/23 08:21:24
what's the reason to introduce two targets?
achaulk
2014/04/23 14:51:32
It used to be the unittest code wouldn't compile w
| |
| 34 'type': 'static_library', | |
| 35 'dependencies': [ | |
| 36 '../base/base.gyp:base', | |
| 37 'feedback_proto', | |
| 38 ], | |
| 39 'include_dirs': [ | |
| 40 '..', | |
| 41 ], | |
| 42 'defines': [ | |
| 43 ], | |
| 44 'sources': [ | |
| 45 'feedback/feedback_data.cc', | |
| 46 'feedback/feedback_data.h', | |
| 47 'feedback/feedback_report.cc', | |
| 48 'feedback/feedback_report.h', | |
| 49 'feedback/feedback_uploader.cc', | |
| 50 'feedback/feedback_uploader.h', | |
| 51 'feedback/feedback_util.cc', | |
| 52 'feedback/feedback_util.h', | |
| 53 ], | |
| 54 }, | |
| 55 { | |
| 56 # Protobuf compiler / generate rule for feedback | |
| 57 'target_name': 'feedback_proto', | |
| 58 'type': 'static_library', | |
| 59 'sources': [ | |
| 60 'feedback/proto/annotations.proto', | |
| 61 'feedback/proto/chrome.proto', | |
| 62 'feedback/proto/common.proto', | |
| 63 'feedback/proto/dom.proto', | |
| 64 'feedback/proto/extension.proto', | |
| 65 'feedback/proto/math.proto', | |
| 66 'feedback/proto/web.proto', | |
| 67 ], | |
| 68 'variables': { | |
| 69 'proto_in_dir': 'feedback/proto', | |
| 70 'proto_out_dir': 'components/feedback/proto', | |
| 71 }, | |
| 72 'includes': [ '../build/protoc.gypi' ] | |
| 73 }, | |
| 74 ], | |
| 75 } | |
| OLD | NEW |
