Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: components/feedback.gypi

Issue 225183018: Move feedback files into src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback.gypi
diff --git a/components/metrics.gypi b/components/feedback.gypi
similarity index 65%
copy from components/metrics.gypi
copy to components/feedback.gypi
index 6036cae0cf91e3ef123fbdb65ffb35b7a63ebd35..1b86b280036a798a5087849f3c08540a979babcf 100644
--- a/components/metrics.gypi
+++ b/components/feedback.gypi
@@ -5,18 +5,21 @@
{
'targets': [
{
- 'target_name': 'metrics',
- 'type': 'static_library',
+ 'target_name': 'feedback_component',
+ 'type': '<(component)',
jochen (gone - plz use gerrit) 2014/04/08 07:45:35 if you want to use <(component), you need to creat
achaulk 2014/04/09 20:09:22 I have no idea what this does, I just copied it fr
+ 'dependencies': [
+ '../base/base.gyp:base',
+ ],
'include_dirs': [
'..',
],
- 'dependencies': [
- '../base/base.gyp:base',
+ 'defines': [
],
'sources': [
- 'metrics/metrics_hashes.cc',
- 'metrics/metrics_hashes.h',
+ 'feedback/feedback_report.cc',
jochen (gone - plz use gerrit) 2014/04/08 07:45:35 please also list the header files
achaulk 2014/04/09 20:09:22 Done.
+ 'feedback/feedback_uploader.cc',
],
},
+
],
}

Powered by Google App Engine
This is Rietveld 408576698