Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: components/feedback.gypi

Issue 225183018: Move feedback files into src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'metrics', 8 'target_name': 'feedback_component',
9 'type': 'static_library', 9 'type': '<(component)',
jochen (gone - plz use gerrit) 2014/04/08 07:45:35 if you want to use <(component), you need to creat
achaulk 2014/04/09 20:09:22 I have no idea what this does, I just copied it fr
10 'dependencies': [
11 '../base/base.gyp:base',
12 ],
10 'include_dirs': [ 13 'include_dirs': [
11 '..', 14 '..',
12 ], 15 ],
13 'dependencies': [ 16 'defines': [
14 '../base/base.gyp:base',
15 ], 17 ],
16 'sources': [ 18 'sources': [
17 'metrics/metrics_hashes.cc', 19 'feedback/feedback_report.cc',
jochen (gone - plz use gerrit) 2014/04/08 07:45:35 please also list the header files
achaulk 2014/04/09 20:09:22 Done.
18 'metrics/metrics_hashes.h', 20 'feedback/feedback_uploader.cc',
19 ], 21 ],
20 }, 22 },
23
21 ], 24 ],
22 } 25 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698