Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2251813006: Revert of SkPDF: cache metrics once. (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: cache metrics once. (patchset #4 id:60001 of https://codereview.chromium.org/2253993002/ ) Reason for revert: because Original issue's description: > SkPDF: cache metrics once. > > Motivation: drawText can look up unicode mapping at draw time to see > if ActualText should be used after crrev.com/2084533004 lands. > > For each SkTypeface, only call getAdvancedTypefaceMetrics() once per > document. Cache the result in the SkPDFCanon, indexed by SkFontID. > Also cache PDF FontDescriptors in the canon, also indexed by SkFontID > (Type1 fonts only). > > Simplify PDF font lookup, map SkFontID+SkGlyphID into a uint64_t. Map > that uint64_t to SkPDFFonts. Remove SkPDFCanon::findFont(), > SkPDFCanon::addFont(), SkPDFFont::IsMatch(), and enum SkPDFFont::Match. > > SkPDFFont no longer holds on to ref of SkAdvancedTypefaceMetrics. > Instead, SkPDFFont::GetFontResource() and SkPDFFont::getFontSubset() > get metrics from canon. > > SkPDFFont multybite bool is now a function of type. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253993002 > > Committed: https://skia.googlesource.com/skia/+/0a61270f4ba85d10659fb63a86817b435ec04c94 TBR=bungeman@google.com,halcanary@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/671fec43e51533b9969502c072cd29d88ebef6ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -212 lines) Patch
M src/pdf/SkPDFCanon.h View 4 chunks +17 lines, -5 lines 0 comments Download
M src/pdf/SkPDFCanon.cpp View 1 chunk +40 lines, -13 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 2 chunks +41 lines, -1 line 0 comments Download
M src/pdf/SkPDFFont.h View 5 chunks +56 lines, -22 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 15 chunks +270 lines, -171 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of SkPDF: cache metrics once.
4 years, 4 months ago (2016-08-17 23:28:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251813006/1
4 years, 4 months ago (2016-08-17 23:28:23 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:28:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/671fec43e51533b9969502c072cd29d88ebef6ea

Powered by Google App Engine
This is Rietveld 408576698