Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: src/pdf/SkPDFCanon.cpp

Issue 2251813006: Revert of SkPDF: cache metrics once. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pdf/SkPDFCanon.h ('k') | src/pdf/SkPDFDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFCanon.cpp
diff --git a/src/pdf/SkPDFCanon.cpp b/src/pdf/SkPDFCanon.cpp
index 4e182aecfc417b32b6440fcec091d94e27d7b1ef..3dcf4e9f0f743b66d07aab48061b6dffc6abf28e 100644
--- a/src/pdf/SkPDFCanon.cpp
+++ b/src/pdf/SkPDFCanon.cpp
@@ -12,25 +12,52 @@
////////////////////////////////////////////////////////////////////////////////
-namespace {
-template <typename K, typename V> struct UnrefValue {
- void operator()(K, V** v) { (*v)->unref(); }
-};
-}
+void SkPDFCanon::reset() {
+ for (int i = 0; i < fFontRecords.count(); ++i) {
+ fFontRecords[i].fFont->unref();
+ }
+ fFontRecords.reset();
-SkPDFCanon::~SkPDFCanon() {
+ fFunctionShaderRecords.reset();
+ fAlphaShaderRecords.reset();
+ fImageShaderRecords.reset();
+
// TODO(halcanary): make SkTHashSet work nicely with sk_sp<>,
// or use std::unordered_set<>
fGraphicStateRecords.foreach ([](WrapGS w) { w.fPtr->unref(); });
- fPDFBitmapMap.foreach(UnrefValue<SkBitmapKey, SkPDFObject>());
- fTypefaceMetrics.foreach(UnrefValue<uint32_t, SkAdvancedTypefaceMetrics>());
- fFontDescriptors.foreach(UnrefValue<uint32_t, SkPDFDict>());
- fFontMap.foreach(UnrefValue<uint64_t, SkPDFFont>());
+ fGraphicStateRecords.reset();
+
+ fPDFBitmapMap.foreach([](SkBitmapKey, SkPDFObject** p) { (*p)->unref(); });
+ fPDFBitmapMap.reset();
}
-void SkPDFCanon::reset() {
- this->~SkPDFCanon();
- new (this)SkPDFCanon;
+////////////////////////////////////////////////////////////////////////////////
+
+SkPDFFont* SkPDFCanon::findFont(uint32_t fontID,
+ uint16_t glyphID,
+ SkPDFFont** relatedFontPtr) const {
+ SkASSERT(relatedFontPtr);
+
+ SkPDFFont* relatedFont = nullptr;
+ for (int i = 0; i < fFontRecords.count(); ++i) {
+ SkPDFFont::Match match = SkPDFFont::IsMatch(
+ fFontRecords[i].fFont, fFontRecords[i].fFontID,
+ fFontRecords[i].fGlyphID, fontID, glyphID);
+ if (SkPDFFont::kExact_Match == match) {
+ return fFontRecords[i].fFont;
+ } else if (!relatedFont && SkPDFFont::kRelated_Match == match) {
+ relatedFont = fFontRecords[i].fFont;
+ }
+ }
+ *relatedFontPtr = relatedFont; // May still be nullptr.
+ return nullptr;
+}
+
+void SkPDFCanon::addFont(SkPDFFont* font, uint32_t fontID, uint16_t fGlyphID) {
+ SkPDFCanon::FontRec* rec = fFontRecords.push();
+ rec->fFont = SkRef(font);
+ rec->fFontID = fontID;
+ rec->fGlyphID = fGlyphID;
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « src/pdf/SkPDFCanon.h ('k') | src/pdf/SkPDFDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698