components/ntp_snippets/content_suggestions_provider.h - Issue 2251743002: Refactor OfflinePageSuggestionsProvider dismissed ID handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2251743002: Refactor OfflinePageSuggestionsProvider dismissed ID handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedelete

Patch Set: Fire OnSuggestionInvalidated even if previously dismissed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java ('k') | components/ntp_snippets/content_suggestions_service.h » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_provider.h

diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h

index c9ba0bfc5eea3059da174b32ce902cb9a95a86d1..836fd41996ddd1d2589959e73426e70f72194709 100644

--- a/components/ntp_snippets/content_suggestions_provider.h

+++ b/components/ntp_snippets/content_suggestions_provider.h

@@ -72,7 +72,8 @@ class ContentSuggestionsProvider {

// when the content that the suggestion refers to is gone.

// Note that this event may be fired even if the corresponding |category| is

// not currently AVAILABLE, because open UIs may still be showing the

- // suggestion that is to be removed.

+ // suggestion that is to be removed. This event may also be fired for

+ // |suggestion_id|s that never existed and should be ignored in that case.

virtual void OnSuggestionInvalidated(ContentSuggestionsProvider* provider,

Category category,

const std::string& suggestion_id) = 0;