chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java - Issue 2251743002: Refactor OfflinePageSuggestionsProvider dismissed ID handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

Issue 2251743002: Refactor OfflinePageSuggestionsProvider dismissed ID handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedelete

Patch Set: Fire OnSuggestionInvalidated even if previously dismissed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/ntp_snippets/content_suggestions_provider.h » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

index dfd82b1d5ba2ded50d4429aaf28e55fa2e23a604..28a98db2364003c70b55d8d40fdf9e95aaf1f402 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

@@ -28,7 +28,8 @@ public interface SuggestionsSource {

/**

* Called when a suggestion is invalidated, which means it needs to be removed from the UI

- * immediately.

+ * immediately. This event may be fired for a category or suggestion that does not

+ * currently exist or has never existed and should be ignored in that case.

void onSuggestionInvalidated(@CategoryInt int category, String suggestionId);

}