Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/status/existence/ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index 14729cbc103eba71f56d6e75e3866988f4e69a80..51bc99cc3036bc1ed4d11029bc81ed03157ce8c0 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -657,6 +657,8 @@ TEST_F(ServiceWorkerJobTest, UnregisterWaitingSetsRedundant) {
base::RunLoop().RunUntilIdle();
ASSERT_EQ(SERVICE_WORKER_OK, status);
+ version->set_fetch_handler_existence(
+ ServiceWorkerVersion::FetchHandlerExistence::EXISTS);
version->SetStatus(ServiceWorkerVersion::INSTALLED);
registration->SetWaitingVersion(version);
EXPECT_EQ(EmbeddedWorkerStatus::RUNNING, version->running_status());
@@ -1593,13 +1595,15 @@ TEST_F(ServiceWorkerJobTest, HasFetchHandler) {
helper->set_has_fetch_handler(true);
RunRegisterJob(pattern, script);
registration = FindRegistrationForPattern(pattern);
- EXPECT_TRUE(registration->active_version()->has_fetch_handler());
+ EXPECT_EQ(ServiceWorkerVersion::FetchHandlerExistence::EXISTS,
+ registration->active_version()->fetch_handler_existence());
RunUnregisterJob(pattern);
helper->set_has_fetch_handler(false);
RunRegisterJob(pattern, script);
registration = FindRegistrationForPattern(pattern);
- EXPECT_FALSE(registration->active_version()->has_fetch_handler());
+ EXPECT_EQ(ServiceWorkerVersion::FetchHandlerExistence::DOES_NOT_EXIST,
+ registration->active_version()->fetch_handler_existence());
RunUnregisterJob(pattern);
}

Powered by Google App Engine
This is Rietveld 408576698