Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: content/browser/service_worker/service_worker_handle_unittest.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/status/existence/ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_handle_unittest.cc
diff --git a/content/browser/service_worker/service_worker_handle_unittest.cc b/content/browser/service_worker/service_worker_handle_unittest.cc
index d5a2109d640e222502276e7a708cc63fa6ad66a3..4767ecb01b11c917f8c95d86ba0ae64779ba6c95 100644
--- a/content/browser/service_worker/service_worker_handle_unittest.cc
+++ b/content/browser/service_worker/service_worker_handle_unittest.cc
@@ -93,6 +93,9 @@ class ServiceWorkerHandleTest : public testing::Test {
records.push_back(
ServiceWorkerDatabase::ResourceRecord(10, version_->script_url(), 100));
version_->script_cache_map()->SetResources(records);
+ version_->set_fetch_handler_existence(
+ ServiceWorkerVersion::FetchHandlerExistence::EXISTS);
+ version_->SetStatus(ServiceWorkerVersion::INSTALLING);
// Make the registration findable via storage functions.
helper_->context()->storage()->LazyInitialize(base::Bind(&base::DoNothing));
@@ -150,26 +153,19 @@ TEST_F(ServiceWorkerHandleTest, OnVersionStateChanged) {
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SERVICE_WORKER_OK, status);
- // ...update state to installing...
- version_->SetStatus(ServiceWorkerVersion::INSTALLING);
-
- // ...and update state to installed.
+ // ...update state to installed.
version_->SetStatus(ServiceWorkerVersion::INSTALLED);
- ASSERT_EQ(3UL, ipc_sink()->message_count());
+ ASSERT_EQ(2UL, ipc_sink()->message_count());
ASSERT_EQ(0L, dispatcher_host_->bad_message_received_count_);
// We should be sending 1. StartWorker,
EXPECT_EQ(EmbeddedWorkerMsg_StartWorker::ID,
ipc_sink()->GetMessageAt(0)->type());
- // 2. StateChanged (state == Installing),
- VerifyStateChangedMessage(handle->handle_id(),
- blink::WebServiceWorkerStateInstalling,
- ipc_sink()->GetMessageAt(1));
- // 3. StateChanged (state == Installed).
+ // 2. StateChanged (state == Installed).
VerifyStateChangedMessage(handle->handle_id(),
blink::WebServiceWorkerStateInstalled,
- ipc_sink()->GetMessageAt(2));
+ ipc_sink()->GetMessageAt(1));
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698