Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251583002:
Round GPU tiles to multiple of 64 to work around CA scaling issues (Closed)
DescriptionRound GPU tiles to multiple of 64 to work around CA scaling issues
When scaling tiles using Core Animation, certain tile sizes / scale
factors appear to cause rounding issues and seams between tiles.
Rounding tiles to a multiple of 64 works around the
most obvious case of this, which is seen on the print preview screen.
BUG=632274
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel
Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3
Committed: https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98
Cr-Original-Commit-Position: refs/heads/master@{#412698}
Cr-Commit-Position: refs/heads/master@{#412917}
Patch Set 1 #Patch Set 2 : fix unittests #Patch Set 3 : rebaseline #Patch Set 4 : reland #
Messages
Total messages: 52 (37 generated)
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. While may be needed, rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. While may be needed, rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. While may be needed, rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
ericrk@chromium.org changed reviewers: + vmpstr@chromium.org
lgtm
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Fix unit tests
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/2251583002/#ps20001 (title: "fix unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel,master.tryserver.win10_blink_rel,master.tryserver.blink:mac_10_11_blink_rel ==========
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel,master.tryserver.win10_blink_rel,master.tryserver.blink:mac_10_11_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel,master.tryserver.win10_blink_rel,master.tryserver.blink:mac10.11_blink_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Your CL can not be processed by CQ because of: * Failed to parse additional trybots
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Your CL can not be processed by CQ because of: * Failed to parse additional trybots
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel,master.tryserver.win10_blink_rel,master.tryserver.blink:mac10.11_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Your CL can not be processed by CQ because of: * Failed to parse additional trybots
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/2251583002/#ps40001 (title: "rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2251393002/ by rjwright@chromium.org. The reason for reverting is: virtual/gpu-rasterization/fast/images/color-profile-layer.html virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html virtual/gpu-rasterization/fast/images/color-profile-group.html are failing on Win10/Win7 bots after auto-rebaseline. crbug.com/638822 .
Message was sent while issue was closed.
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ==========
On 2016/08/18 05:41:11, rjwright wrote: > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/2251393002/ by mailto:rjwright@chromium.org. > > The reason for reverting is: > virtual/gpu-rasterization/fast/images/color-profile-layer.html > virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html > virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html > virtual/gpu-rasterization/fast/images/color-profile-group.html > > are failing on Win10/Win7 bots after auto-rebaseline. > > crbug.com/638822 > . flakiness in these tests continued even after revert/rebaseline - looks like another issue snuck in. Tracking windows flakes with a different bug - going to re-land this.
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/2251583002/#ps60001 (title: "reland")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Cr-Commit-Position: refs/heads/master@{#412698} ========== to ========== Round GPU tiles to multiple of 64 to work around CA scaling issues When scaling tiles using Core Animation, certain tile sizes / scale factors appear to cause rounding issues and seams between tiles. Rounding tiles to a multiple of 64 works around the most obvious case of this, which is seen on the print preview screen. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 Committed: https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98 Cr-Original-Commit-Position: refs/heads/master@{#412698} Cr-Commit-Position: refs/heads/master@{#412917} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98 Cr-Commit-Position: refs/heads/master@{#412917} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
