Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225143006: Limit the max volume to 255 before pass it to APM. (Closed)

Created:
6 years, 8 months ago by no longer working on chromium
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Limit the max volume to 255 before pass it to APM. BUG=264611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263624

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
no longer working on chromium
Andrew, please take a look. Thanks, SX
6 years, 8 months ago (2014-04-11 16:59:23 UTC) #1
ajm
lgtm with a comment change. https://codereview.chromium.org/225143006/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/225143006/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode465 content/renderer/media/webrtc_audio_capturer.cc:465: // volume is higher ...
6 years, 8 months ago (2014-04-12 01:53:34 UTC) #2
no longer working on chromium
Thanks. Land soon. https://codereview.chromium.org/225143006/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/225143006/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode465 content/renderer/media/webrtc_audio_capturer.cc:465: // volume is higher than 255. ...
6 years, 8 months ago (2014-04-14 10:06:33 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 8 months ago (2014-04-14 10:06:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/225143006/20001
6 years, 8 months ago (2014-04-14 10:06:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 10:06:45 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-14 10:06:46 UTC) #7
no longer working on chromium
Henrik, can I have your stamp on this patch? Thanks, SX
6 years, 8 months ago (2014-04-14 10:09:56 UTC) #8
henrika (OOO until Aug 14)
LGTM
6 years, 8 months ago (2014-04-14 10:18:00 UTC) #9
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 8 months ago (2014-04-14 10:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/225143006/20001
6 years, 8 months ago (2014-04-14 10:40:28 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 13:47:31 UTC) #12
Message was sent while issue was closed. 
Change committed as 263624

Powered by Google App Engine
This is Rietveld 408576698