Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2251413002: Use testharness.js in image load tests. (Closed)

Created:
4 years, 4 months ago by sivag
Modified:
4 years, 4 months ago
Reviewers:
Srirama, fs
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js in image load tests. This test uses testharness.js to test whether image load event is fired even if the image is the last one we loaded successfully. BUG=637859 . Committed: https://crrev.com/eb35d1f2baf4c0e4b42f8b4d4a33f543c2185597 Cr-Commit-Position: refs/heads/master@{#412806}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed review comments. #

Messages

Total messages: 12 (6 generated)
sivag
@fs, srirama ptal..
4 years, 4 months ago (2016-08-18 10:19:54 UTC) #3
fs
LGTM w/ nits https://codereview.chromium.org/2251413002/diff/1/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html File third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html (right): https://codereview.chromium.org/2251413002/diff/1/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html#newcode13 third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html:13: img.src= resetImage; Nit: Space before = ...
4 years, 4 months ago (2016-08-18 10:44:26 UTC) #4
sivag
https://codereview.chromium.org/2251413002/diff/1/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html File third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html (right): https://codereview.chromium.org/2251413002/diff/1/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html#newcode13 third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html:13: img.src= resetImage; On 2016/08/18 10:44:26, fs wrote: > Nit: ...
4 years, 4 months ago (2016-08-18 10:53:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251413002/20001
4 years, 4 months ago (2016-08-18 10:54:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 12:19:20 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:23:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb35d1f2baf4c0e4b42f8b4d4a33f543c2185597
Cr-Commit-Position: refs/heads/master@{#412806}

Powered by Google App Engine
This is Rietveld 408576698