third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html - Issue 2251413002: Use testharness.js in image load tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html

Issue 2251413002: Use testharness.js in image load tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <title>crbug.com/469678: We should fire an image load event even if the image is the last one we loaded successfully.</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

3 <script>	5 <script>

4 if (window.testRunner) {	6 async_test(function(t) {

5 testRunner.waitUntilDone();	7 var img = new Image();

6 testRunner.dumpAsText();

7 }

8 img = new Image();

9 var onloadCounter = 0;

10 var testImage = 'resources/green.jpg';	8 var testImage = 'resources/green.jpg';

11 var resetImage = 'resources/green.jpg';	9 var resetImage = 'resources/green.jpg';

12 img.onload = function(){	10 // In this test we load an image then we immediately launch another request

13 onloadCounter++;	11 // for the same image - only one load event should be fired. Then we do the

14 debug("Image onload event fired for " + img.src.substring(img.src.lastIn dexOf('/') + 1));	12 // same again: another load event should be fired.

15 if (onloadCounter == 2) {	13 img.onload = t.step_func(function() {

16 document.getElementById('result').textContent = "PASS";	14 img.src = resetImage;

17 if (window.testRunner)

18 testRunner.notifyDone();

19 return;

20 }

21 if (onloadCounter == 1) {

22 setTimeout(function() {

23 img.src= resetImage;

24 img.src = testImage;

25 }, 0);

26 return;

27 }

28 document.getElementById('result').textContent = "FAIL";

29 };

30 setTimeout(function() {

31 img.src= resetImage;

32 img.src = testImage;	15 img.src = testImage;

33 }, 0);	16 img.onload = t.step_func_done();

	17 });

	18 img.src = resetImage;

	19 img.src = testImage;

	20 });

34 </script>	21 </script>

35 <div id="console">

36 crbug.com/469678: We should fire an image load event even if the image is the la st one we loaded successfully.<br>

37 In this test we load an image then we immediately launch an other request for th e same image - only one load event should be fired.<br>

38 Then we do the same again: another load event should be fired.<br>

39 </div>

40 <div id="result">FAIL</div>

OLD	NEW