third_party/WebKit/Source/core/frame/FrameView.h - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.h

diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h

index 55f071cafc334489d06d45c50113a5303dd18096..e017707b4370697b96652e2ca5b1af3cdcd4f864 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.h

+++ b/third_party/WebKit/Source/core/frame/FrameView.h

@@ -210,11 +210,6 @@ public:

const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { return m_viewportConstrainedObjects.get(); }

bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }

- // Sticky objects.

- void addStickyPositionObject() { ++m_stickyPositionObjectCount; }

- void removeStickyPositionObject() { --m_stickyPositionObjectCount; }

- bool hasStickyPositionObjects() const { return m_stickyPositionObjectCount; }

// Objects with background-attachment:fixed.

void addBackgroundAttachmentFixedObject(LayoutObject*);

void removeBackgroundAttachmentFixedObject(LayoutObject*);