third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 6c6ec933ce0598843aae45578a2128c3483ef273..163e1a647197ef2ea421db18db252b6f6a74b149 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -282,7 +282,6 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt

if (newStyleIsSticky != oldStyleIsSticky) {

if (newStyleIsSticky) {

- frameView->addStickyPositionObject();

// During compositing inputs update we'll have the scroll

// ancestor without having to walk up the tree and can compute

// the sticky position constraints then.

@@ -292,7 +291,6 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt

// This may get re-added to viewport constrained objects if the object went

// from sticky to fixed.

frameView->removeViewportConstrainedObject(this);

- frameView->removeStickyPositionObject();

// Remove sticky constraints for this layer.

if (layer()) {