Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: components/translate/core/browser/translate_script.cc

Issue 2251273002: pass script fetch start / end time to Transalte Element to implement real time latency monitoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_script.cc
diff --git a/components/translate/core/browser/translate_script.cc b/components/translate/core/browser/translate_script.cc
index 875fc7f45e3633100129b3a6e55b036f00295650..ca39852435ad0bd8668ddbb3b442682da7aa2969 100644
--- a/components/translate/core/browser/translate_script.cc
+++ b/components/translate/core/browser/translate_script.cc
@@ -61,6 +61,8 @@ TranslateScript::~TranslateScript() {
}
void TranslateScript::Request(const RequestCallback& callback) {
+ script_fetch_start_time_ = base::Time::Now().ToJsTime();
+
DCHECK(data_.empty()) << "Do not fetch the script if it is already fetched";
callback_list_.push_back(callback);
@@ -142,6 +144,9 @@ void TranslateScript::OnScriptFetchComplete(
if (variations::GetVariationParams(kTranslateServerStudy, &params)) {
server_params = params[kServerParams];
}
+ base::StringAppendF(
+ &data_, "var gtTimeInfo = {'fetchStart': %f, 'fetchEnd': %f};\n",
groby-ooo-7-16 2016/08/18 22:35:04 Question - wouldn't it make more sense to report j
ftang 2016/08/18 23:01:39 I need time (at least one of them) so my js in the
+ script_fetch_start_time_, base::Time::Now().ToJsTime());
base::StringAppendF(&data_, "var serverParams = '%s';\n",
server_params.c_str());

Powered by Google App Engine
This is Rietveld 408576698