Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: components/translate/core/browser/resources/translate.js

Issue 2251273002: pass script fetch start / end time to Transalte Element to implement real time latency monitoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/resources/translate.js
diff --git a/components/translate/core/browser/resources/translate.js b/components/translate/core/browser/resources/translate.js
index 79c579342531c9bce86a66ca16d3e7a6db98738c..7dd7568bdaad685bff8a69af4672c29f7c7643d8 100644
--- a/components/translate/core/browser/resources/translate.js
+++ b/components/translate/core/browser/resources/translate.js
@@ -259,14 +259,17 @@ cr.googleTranslate = (function() {
// translateApiKey is predefined by translate_script.cc.
'key': translateApiKey,
'serverParams': serverParams,
+ 'timeInfo': gtTimeInfo,
groby-ooo-7-16 2016/08/18 22:35:04 key is 'timeInfo' here, 'gtTimeInfo' in test - may
ftang 2016/08/18 23:01:39 the JavaScript variable in the test is gtTimeInfo.
groby-ooo-7-16 2016/08/19 18:20:59 Ah, I see - thank you for the explanation.
ftang 2016/08/19 20:33:23 Acknowledged.
'useSecureConnection': true
});
translateApiKey = undefined;
serverParams = undefined;
+ gtTimeInfo = undefined;
} catch (err) {
errorCode = ERROR['INITIALIZATION_ERROR'];
translateApiKey = undefined;
serverParams = undefined;
+ gtTimeInfo = undefined;
return;
}
// The TranslateService is not available immediately as it needs to start

Powered by Google App Engine
This is Rietveld 408576698