chrome/browser/ui/passwords/password_manager_presenter.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc ('k') | chrome/browser/ui/startup/default_browser_infobar_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_manager_presenter.cc

diff --git a/chrome/browser/ui/passwords/password_manager_presenter.cc b/chrome/browser/ui/passwords/password_manager_presenter.cc

index d9ace94888376d82dc1674f42f360d150b94ae9a..d271456ea25bffb9807e22d2b70a955fe6391e01 100644

--- a/chrome/browser/ui/passwords/password_manager_presenter.cc

+++ b/chrome/browser/ui/passwords/password_manager_presenter.cc

@@ -248,7 +248,7 @@ PasswordManagerPresenter::GetAllPasswords() {

std::vector<std::unique_ptr<autofill::PasswordForm>> ret_val;

for (const auto& form : password_list_) {

- ret_val.push_back(base::WrapUnique(new autofill::PasswordForm(*form)));

+ ret_val.push_back(base::MakeUnique<autofill::PasswordForm>(*form));

}

return ret_val;