chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | chrome/browser/ui/passwords/password_manager_presenter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

index c112fedb47e56692d57fa4812b52970c79172d33..874ac9340a0690892476b925ad07df8e537ede2f 100644

--- a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

+++ b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

@@ -88,11 +88,11 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooser) {

local_form2.username_value = base::ASCIIToUTF16(kUsername2);

autofill::PasswordForm idp_form = GetFederationProviderForm();

std::vector<std::unique_ptr<autofill::PasswordForm>> locals;

- locals.push_back(base::WrapUnique(new autofill::PasswordForm(local_form)));

- locals.push_back(base::WrapUnique(new autofill::PasswordForm(local_form2)));

+ locals.push_back(base::MakeUnique<autofill::PasswordForm>(local_form));

+ locals.push_back(base::MakeUnique<autofill::PasswordForm>(local_form2));

autofill::PasswordForm* local_form_ptr = locals[0].get();

std::vector<std::unique_ptr<autofill::PasswordForm>> federations;

- federations.push_back(base::WrapUnique(new autofill::PasswordForm(idp_form)));

+ federations.push_back(base::MakeUnique<autofill::PasswordForm>(idp_form));

EXPECT_CALL(prompt, ShowAccountChooser());

controller().ShowAccountChooser(&prompt,

@@ -126,7 +126,7 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooserAndSignIn) {

StrictMock<MockPasswordPrompt> prompt;

autofill::PasswordForm local_form = GetLocalForm();

std::vector<std::unique_ptr<autofill::PasswordForm>> locals;

- locals.push_back(base::WrapUnique(new autofill::PasswordForm(local_form)));

+ locals.push_back(base::MakeUnique<autofill::PasswordForm>(local_form));

std::vector<std::unique_ptr<autofill::PasswordForm>> federations;

EXPECT_CALL(prompt, ShowAccountChooser());

@@ -156,8 +156,7 @@ TEST_F(PasswordDialogControllerTest, AccountChooserClosed) {

base::HistogramTester histogram_tester;

StrictMock<MockPasswordPrompt> prompt;

std::vector<std::unique_ptr<autofill::PasswordForm>> locals;

- locals.push_back(

- base::WrapUnique(new autofill::PasswordForm(GetLocalForm())));

+ locals.push_back(base::MakeUnique<autofill::PasswordForm>(GetLocalForm()));

EXPECT_CALL(prompt, ShowAccountChooser());

controller().ShowAccountChooser(&prompt, std::move(locals),

PasswordDialogController::FormsVector());