Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6168)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller.h

Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/immersive_mode_controller.h
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller.h b/chrome/browser/ui/views/frame/immersive_mode_controller.h
index 1fed753fd3d9ba609c86719e9169e3721a515922..510b011f132fe36c215cb11bfbd9032e653b1b1a 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller.h
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller.h
@@ -39,6 +39,12 @@ class ImmersiveModeController {
ANIMATE_REVEAL_NO
};
+ // TODO(sky): remove this, temporary while supporting both ash and mash.
+ enum class Type {
+ ASH,
+ STUB,
+ };
+
class Observer {
public:
// Called when a reveal of the top-of-window views has been initiated.
@@ -51,7 +57,7 @@ class ImmersiveModeController {
virtual ~Observer() {}
};
- ImmersiveModeController();
+ explicit ImmersiveModeController(Type type);
virtual ~ImmersiveModeController();
// Must initialize after browser view has a Widget and native window.
@@ -100,10 +106,7 @@ class ImmersiveModeController {
virtual void OnFindBarVisibleBoundsChanged(
const gfx::Rect& new_visible_bounds_in_screen) = 0;
- // Disables animations and moves the mouse so that it is not over the
- // top-of-window views for the sake of testing. Must be called before
- // enabling immersive fullscreen.
- virtual void SetupForTest() = 0;
+ Type type() const { return type_; }
virtual void AddObserver(Observer* observer);
virtual void RemoveObserver(Observer* observer);
@@ -112,6 +115,8 @@ class ImmersiveModeController {
base::ObserverList<Observer> observers_;
private:
+ const Type type_;
+
DISALLOW_COPY_AND_ASSIGN(ImmersiveModeController);
};

Powered by Google App Engine
This is Rietveld 408576698