chrome/browser/ui/views/frame/browser_view_layout_unittest.cc - Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

diff --git a/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc b/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

index 840f366a9cb174a33a17a1423e0e164f25ed7aad..0ad5522bdc83cb3a89f772ed14f1f5ec7e0c990c 100644

--- a/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

+++ b/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

@@ -92,7 +92,7 @@ class MockView : public views::View {

class MockImmersiveModeController : public ImmersiveModeController {

public:

- MockImmersiveModeController() {}

+ MockImmersiveModeController() : ImmersiveModeController(Type::STUB) {}

~MockImmersiveModeController() override {}

// ImmersiveModeController overrides:

@@ -112,7 +112,6 @@ class MockImmersiveModeController : public ImmersiveModeController {

}

void OnFindBarVisibleBoundsChanged(

const gfx::Rect& new_visible_bounds) override {}

- void SetupForTest() override {}

private:

DISALLOW_COPY_AND_ASSIGN(MockImmersiveModeController);