Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251203003:
DevTools: Remove 200ms delay in console prompt (Closed)
|
Created:
4 years, 4 months ago by luoe Modified:
4 years, 4 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Remove 200ms delay in console prompt
BUG=638770
Committed: https://crrev.com/c98c06dde53b992bc75066b28d0156813bd8c0a9
Cr-Commit-Position: refs/heads/master@{#412922}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Added return #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Description was changed from ========== Fix scroll again BUG=638770 ========== to ========== DevTools: Remove 200ms delay in console prompt BUG=638770 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
luoe@chromium.org changed reviewers: + dgozman@chromium.org, lushnikov@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:773: if (event.key === "PageUp") { WebInspector.KeyboardShortcut.Keys.PageUp https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:774: this._updateStickToBottomOnWheel(); return after that?
https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:773: if (event.key === "PageUp") { On 2016/08/18 03:32:36, pfeldman wrote: > WebInspector.KeyboardShortcut.Keys.PageUp While updating the console-viewport-stick-to-bottom.html test, I found out that creating and dispatching a keyboard event in Chrome will always have keyCode == 0. To workaround this known bug, I went with event.key instead, which we already use more often than keyCode. According to MDN, keyCode is deprecated, so I think we should keep this instance and have a future CL to convert keyCode's into key's and turn strings into enums. https://codereview.chromium.org/2251203003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:774: this._updateStickToBottomOnWheel(); On 2016/08/18 03:32:36, pfeldman wrote: > return after that? Done.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2251203003/#ps20001 (title: "Added return")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: Remove 200ms delay in console prompt BUG=638770 ========== to ========== DevTools: Remove 200ms delay in console prompt BUG=638770 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Remove 200ms delay in console prompt BUG=638770 ========== to ========== DevTools: Remove 200ms delay in console prompt BUG=638770 Committed: https://crrev.com/c98c06dde53b992bc75066b28d0156813bd8c0a9 Cr-Commit-Position: refs/heads/master@{#412922} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c98c06dde53b992bc75066b28d0156813bd8c0a9 Cr-Commit-Position: refs/heads/master@{#412922} |
