cc: Reland Move data to LayerTree from LayerTreeHost.

cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d
Cr-Commit-Position: refs/heads/master@{#412655}

[Khushal, 2016-08-17 18:15:45]

Description was changed from

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
==========

to

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Khushal, 2016-08-17 18:15:46]

Description was changed from

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-17 18:16:03]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Ian Vollick, 2016-08-17 18:18:49]

On 2016/08/17 18:16:04, Khushal wrote:

Is it possible to upload to the previous issue so that we can see diffs?

[Khushal, 2016-08-17 18:23:00]

On 2016/08/17 18:18:49, vollick wrote:
> On 2016/08/17 18:16:04, Khushal wrote:
> 
> Is it possible to upload to the previous issue so that we can see diffs?

Done.

[Ian Vollick, 2016-08-17 18:27:17]

On 2016/08/17 18:23:00, Khushal wrote:
> On 2016/08/17 18:18:49, vollick wrote:
> > On 2016/08/17 18:16:04, Khushal wrote:
> > 
> > Is it possible to upload to the previous issue so that we can see diffs?
> 
> Done.

Ah, this works, too. Fix lgtm.

[Khushal, 2016-08-17 18:43:55]

https://codereview.chromium.org/2251143002/diff/60001/cc/layers/layer_unittes...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2251143002/diff/60001/cc/layers/layer_unittes...
cc/layers/layer_unittest.cc:904: // We pass the raw pointer to the AnimationHost
to the MockLayerTree here,
Added a comment to explain the weird release and wrapping again. PTAL.

[Ian Vollick, 2016-08-17 18:52:32]

On 2016/08/17 18:43:55, Khushal wrote:
>
https://codereview.chromium.org/2251143002/diff/60001/cc/layers/layer_unittes...
> File cc/layers/layer_unittest.cc (right):
> 
>
https://codereview.chromium.org/2251143002/diff/60001/cc/layers/layer_unittes...
> cc/layers/layer_unittest.cc:904: // We pass the raw pointer to the
AnimationHost
> to the MockLayerTree here,
> Added a comment to explain the weird release and wrapping again. PTAL.

Thanks for the comment. still lgtm.

[piman, 2016-08-17 18:55:52]

lgtm

[Khushal, 2016-08-17 19:13:30]

Description was changed from

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-17 19:13:30]

khushalsagar@chromium.org changed reviewers:
+ danakj@chromium.org

[Khushal, 2016-08-17 19:21:00]

Description was changed from

==========
Reland this with the fix


Revert "Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9
id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland Move data to LayerTree from LayerTreeHost.

Revert "Revert of cc: Move data to LayerTree from LayerTreeHost.
(patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-17 19:36:05]

Description was changed from

==========
cc: Reland Move data to LayerTree from LayerTreeHost.

Revert "Revert of cc: Move data to LayerTree from LayerTreeHost.
(patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland Move data to LayerTree from LayerTreeHost.

Revert "Revert of cc: Move data to LayerTree from LayerTreeHost.
(patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-08-17 19:46:49]

That fix LGTM. Can you copy the CL description from the original CL over here
since you're not reusing it (and you don't really need to reference that this is
a revert of revert).

[Khushal, 2016-08-17 19:58:12]

Description was changed from

==========
cc: Reland Move data to LayerTree from LayerTreeHost.

Revert "Revert of cc: Move data to LayerTree from LayerTreeHost.
(patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )"

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-17 19:58:34]

Description was changed from

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

This reverts commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-17 19:58:51]

On 2016/08/17 19:46:49, danakj wrote:
> That fix LGTM. Can you copy the CL description from the original CL over here
> since you're not reusing it (and you don't really need to reference that this
is
> a revert of revert).

Done. Thanks!

[Khushal, 2016-08-17 19:58:59]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-08-17 19:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2251143002/#ps80001
(title: "better fix?")

[commit-bot: I haz the power, 2016-08-17 19:59:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-08-17 20:28:15]

lgtm

https://codereview.chromium.org/2251143002/diff/80001/cc/layers/layer_proto_c...
File cc/layers/layer_proto_converter.h (right):

https://codereview.chromium.org/2251143002/diff/80001/cc/layers/layer_proto_c...
cc/layers/layer_proto_converter.h:37: LayerTreeHost* layer_tree);
nit: this is still a layer_tree_host.

https://codereview.chromium.org/2251143002/diff/80001/cc/test/fake_layer_tree...
File cc/test/fake_layer_tree_host.cc (right):

https://codereview.chromium.org/2251143002/diff/80001/cc/test/fake_layer_tree...
cc/test/fake_layer_tree_host.cc:20: FakeLayerTree(std::unique_ptr<AnimationHost>
animation_host,
minor nit: this could be templatized with a parameter pack so that you don't
have to update it if layer tree ctor changes

[commit-bot: I haz the power, 2016-08-17 21:49:28]

Description was changed from

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-17 21:49:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-17 21:53:29]

Description was changed from

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Reland "Move data to LayerTree from LayerTreeHost."

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

The test was casting a MockLayerTree to a StrictMock<MockLayerTree>.
Make sure to create the correct type.

TBR=vollick,piman

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d
Cr-Commit-Position: refs/heads/master@{#412655}
==========

[commit-bot: I haz the power, 2016-08-17 21:53:30]

Patchset 5 (id:??) landed as
https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d
Cr-Commit-Position: refs/heads/master@{#412655}