Issue 225103004: Revert 261654 "Move some extension constants out of //chrome."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225103004: Revert 261654 "Move some extension constants out of //chrome." (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)

Modified:
6 years, 8 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 261654 "Move some extension constants out of //chrome." This broke the Linux GTK builder, > Move some extension constants out of //chrome. > > This will help move additional chrome-independent extensions code out of //chrome and into //extensions. > > clang_format also applied; please pardon the dust. > > BUG=359173 > TBR=cpu@chromium.org for component_updater header update > TBR=avi@chromium.org for tab_contents header update > TBR=pkasting@chromium.org for infobars header update > > Review URL: https://codereview.chromium.org/222663002 TBR=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261673

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+299 lines, -304 lines)			Patch
M	trunk/src/chrome/browser/component_updater/component_unpacker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/capture_web_contents_function.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/tabs/windows_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_action.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_icon_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_install_prompt.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_service.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_uninstall_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/image_loader_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/install_signer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/tab_contents/background_contents.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/apps/chrome_app_window_delegate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/browser.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/options/browser_options_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/api/extension_action/action_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/extension_constants.h	View	1 chunk	+253 lines, -219 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/extension_constants.cc	View	2 chunks	+25 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/extension_icon_set_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/manifest_handlers/icons_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/common/localized_error.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/extensions/extension_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/extensions/common/constants.h	View	2 chunks	+0 lines, -40 lines	0 comments	Download
M	trunk/src/extensions/common/constants.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

6 years, 8 months ago (2014-04-04 04:42:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r261673 (tree was closed).

Expand Messages | Collapse Messages