Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222663002: Move some extension constants out of //chrome (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, tfarina, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move some extension constants out of //chrome. This will help move additional chrome-independent extensions code out of //chrome and into //extensions. clang_format also applied; please pardon the dust. BUG=359173 TBR=cpu@chromium.org for component_updater header update TBR=avi@chromium.org for tab_contents header update TBR=pkasting@chromium.org for infobars header update Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261654

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : oops mac #

Patch Set 4 : -- #

Patch Set 5 : rebase #

Patch Set 6 : weeeeeeird patch crossover fail #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -313 lines) Patch
M chrome/browser/component_updater/component_unpacker.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/capture_web_contents_function.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/windows_util.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_signer.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_delegate.cc View 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 2 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 5 1 chunk +233 lines, -267 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 5 2 chunks +1 line, -25 lines 0 comments Download
M chrome/common/extensions/extension_icon_set_unittest.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/localized_error.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 5 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/constants.h View 5 2 chunks +40 lines, -0 lines 0 comments Download
M extensions/common/constants.cc View 5 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Ken Rockot(use gerrit already)
Antony could you take a look at this?
6 years, 8 months ago (2014-04-02 18:24:18 UTC) #1
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/222663002/diff/1/chrome/common/extensions/extension_constants.h File chrome/common/extensions/extension_constants.h (right): https://codereview.chromium.org/222663002/diff/1/chrome/common/extensions/extension_constants.h#newcode237 chrome/common/extensions/extension_constants.h:237: extern const char kChromeVoxExtensionId[]; While we're re-ordering these ...
6 years, 8 months ago (2014-04-02 21:04:31 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 00:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/20001
6 years, 8 months ago (2014-04-03 00:54:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 02:09:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-03 02:09:41 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 04:08:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/40001
6 years, 8 months ago (2014-04-03 04:10:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 04:55:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-03 04:55:55 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 04:58:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/40001
6 years, 8 months ago (2014-04-03 04:58:55 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:41 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:42 UTC) #14
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 14:46:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/40001
6 years, 8 months ago (2014-04-03 14:47:02 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 16:27:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 16:27:36 UTC) #18
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 16:35:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/60001
6 years, 8 months ago (2014-04-03 16:35:42 UTC) #20
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-04 00:00:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/222663002/120001
6 years, 8 months ago (2014-04-04 00:00:49 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 03:46:06 UTC) #23
Message was sent while issue was closed. 
Change committed as 261654

Powered by Google App Engine
This is Rietveld 408576698