chrome/browser/permissions/permission_decision_auto_blocker.h - Issue 2250993002: Add prior dismissal and ignore count metrics for all permission actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_decision_auto_blocker.h

Issue 2250993002: Add prior dismissal and ignore count metrics for all permission actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kendra-permission-action-reporting

Patch Set: Comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_context_base_unittest.cc ('k') | chrome/browser/permissions/permission_decision_auto_blocker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_decision_auto_blocker.h

diff --git a/chrome/browser/permissions/permission_decision_auto_blocker.h b/chrome/browser/permissions/permission_decision_auto_blocker.h

index 6f65f4a8102d180ee41be2a322f0c887a41a72c3..43d863f4eb2f8eb870de5128257dc71e611da64f 100644

--- a/chrome/browser/permissions/permission_decision_auto_blocker.h

+++ b/chrome/browser/permissions/permission_decision_auto_blocker.h

@@ -48,20 +48,6 @@ class PermissionDecisionAutoBlocker {

static const char kPromptDismissCountKey[];

static const char kPromptIgnoreCountKey[];

- // Returns the current number of actions recorded under |key| for |permission|

- // type at |url|.

- static int GetActionCount(const GURL& url,

- content::PermissionType permission,

- const char* key,

- Profile* profile);

- // Records that the user performed an action for a prompt of type |permission|

- // on |url| to a website setting keyed by |key|. Returns the total number of

- // |key| actions which have been performed for |url|.

- int RecordActionInWebsiteSettings(const GURL& url,

- content::PermissionType permission,

- const char* key);

// Updates |prompt_dismissals_before_block_|.

void UpdateFromVariations();