Add prior dismissal and ignore count metrics for all permission actions.

chrome/browser/permissions/permission_decision_auto_blocker.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_DECISION_AUTO_BLOCKER_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_DECISION_AUTO_BLOCKER_H_
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "content/public/browser/permission_type.h"
@@ skipping 15 matching lines @@
                              Profile* profile);
 
   // Returns the current number of ignores recorded for |permission|
   // type at |url|.
   static int GetIgnoreCount(const GURL& url,
                             content::PermissionType permission,
                             Profile* profile);
 
   explicit PermissionDecisionAutoBlocker(Profile* profile);
 
   // Records that an ignore of a prompt for |permission| was made.

[kcarattini, 2016/08/23 04:28:46]

You may want to clarify where this is recorded, and add a note that this should
be called after any PermissionUmaUtil Record methods in order to get the prior
metrics correct. I think the order is still wrong in permission_request_impl.cc
(I'll send a followup cl).

[dominickn, 2016/08/23 20:15:44]

Will clarify this in a follow up CL which splits out block ignoring from
ShouldChangeDismissalToBlock.

   int RecordIgnore(const GURL& url, content::PermissionType permission);
 
   // Records that a dismissal of a prompt for |permission| was made, and returns
   // true if this dismissal should be considered a block. False otherwise.
   bool ShouldChangeDismissalToBlock(const GURL& url,
                                     content::PermissionType permission);
 
  private:
   friend class PermissionContextBaseTests;
 
   // Keys used for storing count data in a website setting.
   static const char kPromptDismissCountKey[];
   static const char kPromptIgnoreCountKey[];
 
-  // Returns the current number of actions recorded under |key| for |permission|
-  // type at |url|.
-  static int GetActionCount(const GURL& url,
-                            content::PermissionType permission,
-                            const char* key,
-                            Profile* profile);
-
-  // Records that the user performed an action for a prompt of type |permission|
-  // on |url| to a website setting keyed by |key|. Returns the total number of
-  // |key| actions which have been performed for |url|.
-  int RecordActionInWebsiteSettings(const GURL& url,
-                                    content::PermissionType permission,
-                                    const char* key);
-
   // Updates |prompt_dismissals_before_block_|.
   void UpdateFromVariations();
 
   Profile *profile_;
   int prompt_dismissals_before_block_;
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_DECISION_AUTO_BLOCKER_H_