Add prior dismissal and ignore count metrics for all permission actions.

chrome/browser/permissions/permission_uma_util.h

Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index e920c3e3a918576f7a20dc5bb27a5831a7b62242..16281cb6ca746c838b94df866870f60a187ffdd0 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -40,11 +40,19 @@ class PermissionUmaUtil {
   static const char kPermissionsPromptShownGesture[];
   static const char kPermissionsPromptShownNoGesture[];
   static const char kPermissionsPromptAccepted[];
+  static const char kPermissionsPromptAcceptedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptAcceptedPriorIgnoreCountPrefix[];
   static const char kPermissionsPromptAcceptedGesture[];
   static const char kPermissionsPromptAcceptedNoGesture[];
   static const char kPermissionsPromptDenied[];
+  static const char kPermissionsPromptDeniedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptDeniedPriorIgnoreCountPrefix[];
   static const char kPermissionsPromptDeniedGesture[];
   static const char kPermissionsPromptDeniedNoGesture[];
+  static const char kPermissionsPromptDismissedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptDismissedPriorIgnoreCountPrefix[];
+  static const char kPermissionsPromptIgnoredPriorDismissCountPrefix[];
+  static const char kPermissionsPromptIgnoredPriorIgnoreCountPrefix[];

[raymes, 2016/08/22 02:55:09]

If these aren't used externally, can we just put them in the anonymous namespace
in the cc file?

[dominickn, 2016/08/22 22:40:51]

Arguably all the strings here that are like that should be in the anonymous
namespace. I'd like to defer that to later.

   static const char kPermissionsPromptRequestsPerPrompt[];
   static const char kPermissionsPromptMergedBubbleTypes[];
   static const char kPermissionsPromptMergedBubbleAccepted[];
@@ -99,16 +107,6 @@ class PermissionUmaUtil {
   static void PermissionPromptDenied(
       const std::vector<PermissionRequest*>& requests);
 
-  // Records |count| total dismissal actions for a prompt of type |permission|
-  // for a single origin.
-  static void PermissionPromptDismissed(content::PermissionType permission,
-                                        int count);
-
-  // Records |count| total ignore actions for a prompt of type |permission| for
-  // a single origin.
-  static void PermissionPromptIgnored(content::PermissionType permission,
-                                      int count);
-
   // A permission prompt was accepted or denied, and the prompt displayed a
   // persistence toggle. Records whether the toggle was enabled (persist) or
   // disabled (don't persist).
@@ -132,6 +130,13 @@ class PermissionUmaUtil {
                                      const GURL& requesting_origin,
                                      Profile* profile);
 
+  // Records |count| total prior actions for a prompt of type |permission|
+  // for a single origin using |prefix| for the metric.
+  static void RecordPermissionPromptPriorCount(
+      content::PermissionType permission,
+      const std::string& prefix,
+      int count);
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
 };