Add prior dismissal and ignore count metrics for all permission actions.

chrome/browser/permissions/permission_uma_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 22 matching lines @@
   SOURCE_UI_NUM,
 };
 
 // Provides a convenient way of logging UMA for permission related operations.
 class PermissionUmaUtil {
  public:
   static const char kPermissionsPromptShown[];
   static const char kPermissionsPromptShownGesture[];
   static const char kPermissionsPromptShownNoGesture[];
   static const char kPermissionsPromptAccepted[];
+  static const char kPermissionsPromptAcceptedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptAcceptedPriorIgnoreCountPrefix[];
   static const char kPermissionsPromptAcceptedGesture[];
   static const char kPermissionsPromptAcceptedNoGesture[];
   static const char kPermissionsPromptDenied[];
+  static const char kPermissionsPromptDeniedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptDeniedPriorIgnoreCountPrefix[];
   static const char kPermissionsPromptDeniedGesture[];
   static const char kPermissionsPromptDeniedNoGesture[];
+  static const char kPermissionsPromptDismissedPriorDismissCountPrefix[];
+  static const char kPermissionsPromptDismissedPriorIgnoreCountPrefix[];
+  static const char kPermissionsPromptIgnoredPriorDismissCountPrefix[];
+  static const char kPermissionsPromptIgnoredPriorIgnoreCountPrefix[];

[raymes, 2016/08/22 02:55:09]

If these aren't used externally, can we just put them in the anonymous namespace
in the cc file?

[dominickn, 2016/08/22 22:40:51]

Arguably all the strings here that are like that should be in the anonymous
namespace. I'd like to defer that to later.

   static const char kPermissionsPromptRequestsPerPrompt[];
   static const char kPermissionsPromptMergedBubbleTypes[];
   static const char kPermissionsPromptMergedBubbleAccepted[];
   static const char kPermissionsPromptMergedBubbleDenied[];
 
   static void PermissionRequested(content::PermissionType permission,
                                   const GURL& requesting_origin,
                                   const GURL& embedding_origin,
                                   Profile* profile);
   static void PermissionGranted(content::PermissionType permission,
@@ skipping 34 matching lines @@
   // Note that for coalesced permission bubbles, PermissionPromptAccepted will
   // always be called, with |accept_states| containing whether each request was
   // accepted or denied.
   static void PermissionPromptAccepted(
       const std::vector<PermissionRequest*>& requests,
       const std::vector<bool>& accept_states);
 
   static void PermissionPromptDenied(
       const std::vector<PermissionRequest*>& requests);
 
-  // Records |count| total dismissal actions for a prompt of type |permission|
-  // for a single origin.
-  static void PermissionPromptDismissed(content::PermissionType permission,
-                                        int count);
-
-  // Records |count| total ignore actions for a prompt of type |permission| for
-  // a single origin.
-  static void PermissionPromptIgnored(content::PermissionType permission,
-                                      int count);
-
   // A permission prompt was accepted or denied, and the prompt displayed a
   // persistence toggle. Records whether the toggle was enabled (persist) or
   // disabled (don't persist).
   static void PermissionPromptAcceptedWithPersistenceToggle(
       content::PermissionType permission,
       bool toggle_enabled);
 
   static void PermissionPromptDeniedWithPersistenceToggle(
       content::PermissionType permission,
       bool toggle_enabled);
 
  private:
   friend class PermissionUmaUtilTest;
 
   static bool IsOptedIntoPermissionActionReporting(Profile* profile);
 
   static void RecordPermissionAction(content::PermissionType permission,
                                      PermissionAction action,
                                      PermissionSourceUI source_ui,
                                      PermissionRequestGestureType gesture_type,
                                      const GURL& requesting_origin,
                                      Profile* profile);
 
+  // Records |count| total prior actions for a prompt of type |permission|
+  // for a single origin using |prefix| for the metric.
+  static void RecordPermissionPromptPriorCount(
+      content::PermissionType permission,
+      const std::string& prefix,
+      int count);
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_