Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 225093020: Remove 2-arg createBuffer from WebAudio (Closed)

Created:
6 years, 8 months ago by Raymond Toy
Modified:
6 years, 8 months ago
CC:
blink-reviews, Raymond Toy
Visibility:
Public.

Description

Remove 2-arg createBuffer from WebAudio Originally the 2-arg createBuffer method was a method for synchronously decoding a blob of encoded audio data. This is no longer allowed in the WebAudio specification. See http://webaudio.github.io/web-audio-api/#methods for the valid createBuffer method. Update tests accordingly. BUG=354133 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171498

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M LayoutTests/webaudio/dom-exceptions.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webaudio/dom-exceptions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webaudio/resources/buffer-loader.js View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Raymond Toy
PTAL. This is the last of the CLs I have planned for removing legacy webaudio ...
6 years, 8 months ago (2014-04-09 19:53:32 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/225093020/diff/40001/LayoutTests/webaudio/resources/buffer-loader.js File LayoutTests/webaudio/resources/buffer-loader.js (right): https://codereview.chromium.org/225093020/diff/40001/LayoutTests/webaudio/resources/buffer-loader.js#newcode18 LayoutTests/webaudio/resources/buffer-loader.js:18: var buffer; This variable isn't needed anymore.
6 years, 8 months ago (2014-04-13 08:33:53 UTC) #2
Raymond Toy
https://codereview.chromium.org/225093020/diff/40001/LayoutTests/webaudio/resources/buffer-loader.js File LayoutTests/webaudio/resources/buffer-loader.js (right): https://codereview.chromium.org/225093020/diff/40001/LayoutTests/webaudio/resources/buffer-loader.js#newcode18 LayoutTests/webaudio/resources/buffer-loader.js:18: var buffer; On 2014/04/13 08:33:54, Ken Russell wrote: > ...
6 years, 8 months ago (2014-04-14 16:47:51 UTC) #3
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 8 months ago (2014-04-14 16:48:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/225093020/60001
6 years, 8 months ago (2014-04-14 16:48:16 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 18:19:13 UTC) #6
Message was sent while issue was closed.
Change committed as 171498

Powered by Google App Engine
This is Rietveld 408576698