Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: LayoutTests/webaudio/resources/buffer-loader.js

Issue 225093020: Remove 2-arg createBuffer from WebAudio (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unused var Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/resources/buffer-loader.js
diff --git a/LayoutTests/webaudio/resources/buffer-loader.js b/LayoutTests/webaudio/resources/buffer-loader.js
index 57f20158064fd9908e14a13ab3e2c3845e34594a..8aa98b4173a7b34bbeaaeecfbbac0c7ad7ca314b 100644
--- a/LayoutTests/webaudio/resources/buffer-loader.js
+++ b/LayoutTests/webaudio/resources/buffer-loader.js
@@ -15,20 +15,20 @@ BufferLoader.prototype.loadBuffer = function(url, index) {
var loader = this;
request.onload = function() {
- var buffer;
- try {
- buffer = loader.context.createBuffer(request.response, false);
- } catch(e) {
- alert('error decoding file data: ' + url);
- }
-
- try {
- loader.bufferList[index] = buffer;
- if (++loader.loadCount == loader.urlList.length)
- loader.onload(loader.bufferList);
- } catch(e) {
- alert('BufferLoader: callback problem');
- }
+ loader.context.decodeAudioData(
+ request.response,
+ function (decodedAudio) {
+ try {
+ loader.bufferList[index] = decodedAudio;
+ if (++loader.loadCount == loader.urlList.length)
+ loader.onload(loader.bufferList);
+ } catch(e) {
+ alert('BufferLoader: unable to load buffer' + index);
+ }
+ },
+ function () {
+ alert('error decoding file data: ' + url);
+ });
}
request.onerror = function() {
« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698