Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto
Patch Set: todo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter.cc b/chrome/browser/safe_browsing/permission_reporter.cc
index 2eb3eff39e5f3022e99273809b80f22ecac3f989..04f1f9f8091685c6445329e9028611dc24d8166d 100644
--- a/chrome/browser/safe_browsing/permission_reporter.cc
+++ b/chrome/browser/safe_browsing/permission_reporter.cc
@@ -150,12 +150,14 @@ void PermissionReporter::SendReport(const GURL& origin,
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- PermissionRequestGestureType gesture_type) {
+ PermissionRequestGestureType gesture_type,
+ int num_prior_dismissals,
+ int num_prior_ignores) {
if (IsReportThresholdExceeded(permission, origin))
return;
std::string serialized_report;
BuildReport(origin, permission, action, source_ui, gesture_type,
- &serialized_report);
+ num_prior_dismissals, num_prior_ignores, &serialized_report);
permission_report_sender_->Send(GURL(kPermissionActionReportingUploadUrl),
serialized_report);
}
@@ -166,6 +168,8 @@ bool PermissionReporter::BuildReport(const GURL& origin,
PermissionAction action,
PermissionSourceUI source_ui,
PermissionRequestGestureType gesture_type,
+ int num_prior_dismissals,
+ int num_prior_ignores,
std::string* output) {
PermissionReport report;
report.set_origin(origin.spec());
@@ -173,6 +177,8 @@ bool PermissionReporter::BuildReport(const GURL& origin,
report.set_action(PermissionActionForReport(action));
report.set_source_ui(SourceUIForReport(source_ui));
report.set_gesture(GestureTypeForReport(gesture_type));
+ report.set_num_prior_dismissals(num_prior_dismissals);
+ report.set_num_prior_ignores(num_prior_ignores);
// Collect platform data.
#if defined(OS_ANDROID)
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.h ('k') | chrome/browser/safe_browsing/permission_reporter_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698