chrome/browser/safe_browsing/permission_reporter_browsertest.cc - Issue 2250893002: Permission Action Reporting: Add num_prior_* fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto

Patch Set: todo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.cc ('k') | chrome/browser/safe_browsing/permission_reporter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

diff --git a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

index 0241e1e7fa5551602614e50b01256ef16b3ccba5..3064f91b0c7829c0c2016b941c933e3797137568 100644

--- a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

+++ b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

@@ -125,6 +125,8 @@ IN_PROC_BROWSER_TEST_F(PermissionReporterBrowserTest,

EXPECT_EQ(PermissionReport::DESKTOP_PLATFORM,

permission_report.platform_type());

EXPECT_EQ(PermissionReport::NO_GESTURE, permission_report.gesture());

+ EXPECT_EQ(0, permission_report.num_prior_dismissals());

+ EXPECT_EQ(0, permission_report.num_prior_ignores());

}

} // namespace safe_browsing