chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java - Issue 2250793003: Separate PaymentRequest initialization and display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

Issue 2250793003: Separate PaymentRequest initialization and display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update payment-request-mock.js Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java ('k') | third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

index 58c56593bcccadb43bab54af3b5f9180174a813b..cbc6dec3c2d601635ef01834f99b1dfcba679dc5 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java

@@ -246,7 +246,8 @@ public class PaymentRequestMetricsTest extends PaymentRequestTestBase {

private void assertOnlySpecificAbortMetricLogged(int abortReason) {

for (int i = 0; i < PaymentRequestMetrics.ABORT_REASON_MAX; ++i) {

- assertEquals((i == abortReason ? 1 : 0),

+ assertEquals(String.format("Found %d instead of %d", i, abortReason),

+ (i == abortReason ? 1 : 0),

RecordHistogram.getHistogramValueCountForTesting(

"PaymentRequest.CheckoutFunnel.Aborted", i));

}