chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java - Issue 2250793003: Separate PaymentRequest initialization and display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2250793003: Separate PaymentRequest initialization and display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update payment-request-mock.js Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

index dac9883873e1f47f848dfb89109f6596fb02aa35..af609332fa795429a0d7bff978671fc7c2ec5195 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

@@ -307,7 +307,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View

private boolean mIsInitialLayoutComplete;

/**

- * Builds and shows the UI for PaymentRequest.

+ * Builds the UI for PaymentRequest.

* @param activity The activity on top of which the UI should be displayed.

* @param client The consumer of the PaymentRequest UI.

@@ -400,8 +400,13 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View

dialogWindow.setGravity(Gravity.CENTER);

dialogWindow.setLayout(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);

dialogWindow.setBackgroundDrawable(new ColorDrawable(Color.TRANSPARENT));

- mDialog.show();

+ }

+ /**

+ * Shows the PaymentRequest UI.

+ */

+ public void show() {

+ mDialog.show();

mClient.getDefaultPaymentInformation(new Callback<PaymentInformation>() {

@Override

public void onResult(PaymentInformation result) {