Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2250753002: arc: Fix ArcPackageSyncableService initialization issue. (Closed)

Created:
4 years, 4 months ago by Josh Horwich
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, sync-reviews_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Fix ArcPackageSyncableService initialization issue. ArcPackageSyncableService should not be started before Arc service is ready. BUG=637058 TEST=Pass sync integration test. TEST=Manual test. No crash when add second user. TBR=stevenjb@chromium.org, pavely@chromium.org Review-Url: https://codereview.chromium.org/2231593004 Cr-Commit-Position: refs/heads/master@{#411696} (cherry picked from commit a0627b05a72e3ddd8b9fbdba6ab93717868a9921) Committed: https://chromium.googlesource.com/chromium/src/+/d7e92bc01d0b627a4d66d5ffce4d686f50771075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Josh Horwich
4 years, 4 months ago (2016-08-16 18:16:03 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d7e92bc01d0b627a4d66d5ffce4d686f50771075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698