Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2231593004: arc: Fix ArcPackageSyncableService initialization issue. (Closed)

Created:
4 years, 4 months ago by lgcheng
Modified:
4 years, 4 months ago
Reviewers:
stevenjb, pavely
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, sync-reviews_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix ArcPackageSyncableService initialization issue. ArcPackageSyncableService should not be started before Arc service is ready. BUG=637058 TEST=Pass sync integration test. TEST=Manual test. No crash when add second user. Committed: https://crrev.com/a0627b05a72e3ddd8b9fbdba6ab93717868a9921 Cr-Commit-Position: refs/heads/master@{#411696}

Patch Set 1 #

Patch Set 2 : arc: Fix ArcPackageSyncableService initialization issue. #

Patch Set 3 : arc: Fix ArcPackageSyncableService initialization issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 1 2 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
lgcheng
Hi Guys, PTAL at this patch. Steven, could you review c/b/ui/app_list/ Pavel, could you review ...
4 years, 4 months ago (2016-08-11 19:56:29 UTC) #9
stevenjb
c/b/ui/app_list/ lgtm
4 years, 4 months ago (2016-08-11 20:55:21 UTC) #11
lgcheng
On 2016/08/11 20:55:21, stevenjb wrote: > c/b/ui/app_list/ lgtm Thanks for review!
4 years, 4 months ago (2016-08-11 20:57:40 UTC) #12
pavely
lgtm
4 years, 4 months ago (2016-08-12 16:59:52 UTC) #13
lgcheng
Thanks for review!
4 years, 4 months ago (2016-08-12 17:01:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231593004/60001
4 years, 4 months ago (2016-08-12 17:41:36 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-12 17:45:32 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:47:52 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0627b05a72e3ddd8b9fbdba6ab93717868a9921
Cr-Commit-Position: refs/heads/master@{#411696}

Powered by Google App Engine
This is Rietveld 408576698