Chromium Code Reviews Chromium Code Reviews
Issue 2250743002:
Increase number of buckets for intent-to-first-commit histogram (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 277706dc0d0fb8f3acc9f4889d0d031bff035d34..57cac6c692b24f61a46b15a65a54c50a0dc9864e 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -5711,6 +5711,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="ChromeGeneratedCustomTab.IntentToFirstCommitNavigationTime" |
| units="ms"> |
| + <obsolete> |
| + Deprecated 10/2016 in favor of .IntentToFirstCommitNavigationTime2.*. |
| + </obsolete> |
| <owner>lizeb@chromium.org</owner> |
| <summary> |
| Time between the intent arrival in a Chrome generated CCT and the first |
| @@ -5719,11 +5722,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram |
| + name="ChromeGeneratedCustomTab.IntentToFirstCommitNavigationTime2.ZoomedIn" |
| + units="ms"> |
| + <owner>lizeb@chromium.org</owner> |
| + <summary> |
| + In "Herb" mode shows the time between the intent arrival in a |
| + Chrome generated CCT and the first navigation commit, if the navigation is |
| + successful. Similar in principle to Startup.FirstCommitNavigationTime. |
| + Zoomed in view: shorter range, more buckets. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram |
| + name="ChromeGeneratedCustomTab.IntentToFirstCommitNavigationTime2.ZoomedOut" |
| + units="ms"> |
| + <owner>lizeb@chromium.org</owner> |
| + <summary> |
| + In "Herb" mode shows the time between the intent arrival in a |
| + Chrome generated CCT and the first navigation commit, if the navigation is |
| + successful. Similar in principle to Startup.FirstCommitNavigationTime. |
| + Zoomed out view: longer time range, less buckets. |
| + </summary> |
| +</histogram> |
|
Ilya Sherman
2016/10/13 00:46:57
nit: Mebbe use a histogram_suffixes element to red
pasko
2016/10/13 11:47:09
Thanks. Done. Is there an easy way to debug suffix
Ilya Sherman
2016/10/13 21:51:04
I think extract_histograms.py expands out all the
|
| + |
| <histogram name="ChromeGeneratedCustomTab.IntentToPageLoadedTime" units="ms"> |
| <owner>lizeb@chromium.org</owner> |
| <summary> |
| - Time between the intent arrival in a Chrome generated CCT and the first |
| - "page loaded" event, if the navigation is successful. |
| + In "Herb" mode shows time between the intent arrival in a Chrome |
| + generated CCT and the first "page loaded" event, if the navigation |
| + is successful. |
| </summary> |
| </histogram> |
| @@ -7857,6 +7885,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </histogram> |
| <histogram name="CustomTabs.IntentToFirstCommitNavigationTime" units="ms"> |
| + <obsolete> |
| + Deprecated 10/2016 in favor of .IntentToFirstCommitNavigationTime2.*. |
| + </obsolete> |
| <owner>lizeb@chromium.org</owner> |
| <summary> |
| Time between the intent arrival in Chrome and the first navigation commit, |
| @@ -7865,11 +7896,34 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="CustomTabs.IntentToFirstCommitNavigationTime2.ZoomedIn" |
| + units="ms"> |
| + <owner>lizeb@chromium.org</owner> |
| + <summary> |
| + Time between the intent arrival to a Custom Tab and the first navigation |
| + commit, if the navigation is successful. Similar in principle to |
| + Startup.FirstCommitNavigationTime. Non-"Herb" mode. Zoomed in |
| + view: shorter range, more buckets. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="CustomTabs.IntentToFirstCommitNavigationTime2.ZoomedOut" |
| + units="ms"> |
| + <owner>lizeb@chromium.org</owner> |
| + <summary> |
| + Time between the intent arrival to a Custom Tab and the first navigation |
| + commit, if the navigation is successful. Similar in principle to |
| + Startup.FirstCommitNavigationTime. Non-"Herb" mode. Zoomed out |
| + view: longer time range, less buckets. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="CustomTabs.IntentToPageLoadedTime" units="ms"> |
| <owner>lizeb@chromium.org</owner> |
| <summary> |
| Time between the intent arrival in Chrome and the first "page |
| - loaded" event, if the navigation is successful. |
| + loaded" event, if the navigation is successful. Non-"Herb" |
| + mode. |
| </summary> |
| </histogram> |
