Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java

Issue 2250743002: Increase number of buckets for intent-to-first-commit histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split into zoomed-in and zoomed-out view with 150 buckets total Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
index 3dae97745605c45db371340b05b4f483ce96b755..2655416593687cabf3eb4f40d5dcc57c3764c8f5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
@@ -118,10 +118,13 @@ class CustomTabObserver extends EmptyTabObserver {
pageLoadFinishedTimestamp - mIntentReceivedTimestamp;
String histogramPrefix = mOpenedByChrome ? "ChromeGeneratedCustomTab" : "CustomTabs";
- // Same bounds and bucket count as "Startup.FirstCommitNavigationTime"
RecordHistogram.recordCustomTimesHistogram(
- histogramPrefix + ".IntentToFirstCommitNavigationTime", timeToPageLoadStartedMs,
- 1, TimeUnit.MINUTES.toMillis(1), TimeUnit.MILLISECONDS, 225);
+ histogramPrefix + ".IntentToFirstCommitNavigationTime2.ZoomedOut",
+ timeToPageLoadStartedMs,
+ 50, TimeUnit.MINUTES.toMillis(10), TimeUnit.MILLISECONDS, 50);
+ RecordHistogram.recordCustomTimesHistogram(
+ histogramPrefix + ".IntentToFirstCommitNavigationTime2.ZoomedIn",
+ timeToPageLoadStartedMs, 200, 1000, TimeUnit.MILLISECONDS, 100);
// Same bounds and bucket count as PLT histograms.
RecordHistogram.recordCustomTimesHistogram(histogramPrefix + ".IntentToPageLoadedTime",
timeToPageLoadFinishedMs, 10, TimeUnit.MINUTES.toMillis(10),
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698