Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2250543003: Add 'hidden' annotations tests pdfium/annots/ (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, tonikitoo
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add 'hidden' annotations tests pdfium/annots/ Originally https://codereview.chromium.org/2239713003/ Patch by tonikitoo@igalia.com CL adds hidden annotation variants to the following existing annotation tests: (pdfium/annots/): - annotation_circle_hidden.pdf - annotation_ellipse_hidden.pdf - annotation_highlight_hidden.pdf - annotation_ink_hidden.pdf - annotation_square_hidden.pdf - annotation_squiggly_hidden.pdf - annotation_strikeout_hidden.pdf - annotation_underline_hidden.pdf (fx/mulobj/new/text_markup/): - new_textmarkup1_hidden.pdf - new_textmarkup1_hidden.pdf.0.png - new_textmarkup2_hidden.pdf - new_textmarkup2_hidden.pdf.0.png - new_textmarkup4_hidden.pdf - new_textmarkup4_hidden.pdf.0.png - new_textmarkup5_hidden.pdf - new_textmarkup5_hidden.pdf.0.png - new_textmarkup7_hidden.pdf - new_textmarkup7_hidden.pdf.0.png - new_textmarkup8_hidden.pdf - new_textmarkup8_hidden.pdf.0.png This is how each pdf test being added was generated: 1) uncompressed the PDF file with qpdf: $ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf 2) editted {pdf_file}_hidden.pdf source manually changing its "/F 4" entry to "/F 2". 3) compress {pdf_file}_hidden.pdf back with qpdf: $ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf Also, note that each PDF file added is accompanied of its own *correct* expected result (png). The behavior fix on PDFium side is happening in [1]. [1] https://codereview.chromium.org/2239853002 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/e4926b9ef62434201008b3e0406c30cb854ccbe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A fx/mulobj/new/text_markup/new_textmarkup1_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup1_hidden_expected.pdf.0.png View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup2_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup2_hidden_expected.pdf.0.png View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup4_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup4_hidden_expected.pdf.0.png View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup5_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup5_hidden_expected.pdf.0.png View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup7_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup7_hidden_expected.pdf.0.png View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup8_hidden.pdf View Binary file 0 comments Download
A fx/mulobj/new/text_markup/new_textmarkup8_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_circle_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_circle_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_ellipse_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_ellipse_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_ink_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_ink_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_square_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_square_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_squiggly_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_squiggly_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_strikeout_hidden.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_strikeout_hidden_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_underline_hidden.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_underline_hidden_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 6 (3 generated)
jaepark
This CL adds test cases for hidden annotations, originally patched by tonikitoo@igalia.com in https://codereview.chromium.org/2239713003 . ...
4 years, 4 months ago (2016-08-16 02:06:55 UTC) #3
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-16 02:09:31 UTC) #4
jaepark
4 years, 4 months ago (2016-08-16 02:14:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4926b9ef62434201008b3e0406c30cb854ccbe5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698