Add 'hidden' annotations tests

Add 'hidden' annotations tests

CL adds "hidden annotation" variants to the existing
annotation tests in

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup2_hidden.pdf
- new_textmarkup4_hidden.pdf
- new_textmarkup5_hidden.pdf
- new_textmarkup7_hidden.pdf
- new_textmarkup8_hidden.pdf

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002

[tonikitoo, 2016-08-11 21:13:01]

tonikitoo@igalia.com changed reviewers:
+ dsinclair@chromium.org, jaepark@google.com, tsepez@chromium.org

[tonikitoo, 2016-08-11 21:13:01]

PTAL (implementation fix is happening in
https://codereview.chromium.org/2239853002/)

[tonikitoo, 2016-08-11 21:15:08]

Description was changed from

==========
Add 'hidden' annotations tests pdfium/annots/

CL adds counterpart hidden annotation tests to the following
existing tests:

- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

This is how each pdf test was generated:

- copied annotation_{blehl}.pdf to annotation_{bleh}_hidden.pdf
- editted annotation_{bleh}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2".

Also, note that each PDF file added is accompanied of its own
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

to

==========
Add 'hidden' annotations tests in pdfium/annots/

CL adds counterpart hidden annotation tests to the following
existing tests:

- annotation_circle.pdf
- annotation_ellipse.pdf
- annotation_highlight.pdf
- annotation_ink.pdf
- annotation_square.pdf
- annotation_squiggly.pdf
- annotation_strikeout.pdf
- annotation_underline.pdf

This is how each pdf test was generated:

- copied annotation_{blehl}.pdf to annotation_{bleh}_hidden.pdf
- editted annotation_{bleh}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2".

Also, note that each PDF file added is accompanied of its
own *correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

[Tom Sepez, 2016-08-11 21:31:39]

On 2016/08/11 21:21:22, tonikitoo1 wrote:

Thanks, tests always welcome.

These should live in testing/resources/pixel/ or
testing/resources/pixel/annots/.
Placing them there will cause the tests to be picked up and run on all of the
bots.

[tonikitoo, 2016-08-12 04:51:56]

On 2016/08/11 21:31:39, Tom Sepez wrote:
> On 2016/08/11 21:21:22, tonikitoo1 wrote:
> 
> Thanks, tests always welcome.
> 
> These should live in testing/resources/pixel/ or
> testing/resources/pixel/annots/.
> Placing them there will cause the tests to be picked up and run on all of the
> bots.

Do you mean we should move the existing tests in testing/corpus/pdfium/annots/
out to testing/resources/pixel/ ?

PS: these are two different Git repositories.

[Tom Sepez, 2016-08-12 15:26:10]

On 2016/08/12 04:51:56, tonikitoo1 wrote:
> On 2016/08/11 21:31:39, Tom Sepez wrote:
> > On 2016/08/11 21:21:22, tonikitoo1 wrote:
> > 
> > Thanks, tests always welcome.
> > 
> > These should live in testing/resources/pixel/ or
> > testing/resources/pixel/annots/.
> > Placing them there will cause the tests to be picked up and run on all of
the
> > bots.
> 
> Do you mean we should move the existing tests in testing/corpus/pdfium/annots/
> out to testing/resources/pixel/ ?
> 
> PS: these are two different Git repositories.

Ah, right, the tests come in two places: a smaller set that lives in the
repository to facilitate unit tests and the like, and the corpus.  So leaving
these in corpus is fine.

[tonikitoo, 2016-08-13 15:35:48]

Description was changed from

==========
Add 'hidden' annotations tests in pdfium/annots/

CL adds counterpart hidden annotation tests to the following
existing tests:

- annotation_circle.pdf
- annotation_ellipse.pdf
- annotation_highlight.pdf
- annotation_ink.pdf
- annotation_square.pdf
- annotation_squiggly.pdf
- annotation_strikeout.pdf
- annotation_underline.pdf

This is how each pdf test was generated:

- copied annotation_{blehl}.pdf to annotation_{bleh}_hidden.pdf
- editted annotation_{bleh}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2".

Also, note that each PDF file added is accompanied of its
own *correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

to

==========
Add 'hidden' annotations tests pdfium/annots/

CL adds hidden annotation variants to the following existing
annotation tests:

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup1_hidden.pdf.0.png
- new_textmarkup2_hidden.pdf
- new_textmarkup2_hidden.pdf.0.png
- new_textmarkup4_hidden.pdf
- new_textmarkup4_hidden.pdf.0.png
- new_textmarkup5_hidden.pdf
- new_textmarkup5_hidden.pdf.0.png
- new_textmarkup7_hidden.pdf
- new_textmarkup7_hidden.pdf.0.png
- new_textmarkup8_hidden.pdf
- new_textmarkup8_hidden.pdf.0.png

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

[tonikitoo, 2016-08-13 15:35:48]

tonikitoo@igalia.com changed reviewers:
+ thestig@chromium.org

[tonikitoo, 2016-08-13 15:37:33]

Description was changed from

==========
Add 'hidden' annotations tests pdfium/annots/

CL adds hidden annotation variants to the following existing
annotation tests:

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup1_hidden.pdf.0.png
- new_textmarkup2_hidden.pdf
- new_textmarkup2_hidden.pdf.0.png
- new_textmarkup4_hidden.pdf
- new_textmarkup4_hidden.pdf.0.png
- new_textmarkup5_hidden.pdf
- new_textmarkup5_hidden.pdf.0.png
- new_textmarkup7_hidden.pdf
- new_textmarkup7_hidden.pdf.0.png
- new_textmarkup8_hidden.pdf
- new_textmarkup8_hidden.pdf.0.png

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

to

==========
Add 'hidden' annotations tests pdfium/annots/

CL adds "hidden annotation" variants to the existing
annotation tests in

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup2_hidden.pdf
- new_textmarkup4_hidden.pdf
- new_textmarkup5_hidden.pdf
- new_textmarkup7_hidden.pdf
- new_textmarkup8_hidden.pdf

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

[tonikitoo, 2016-08-13 15:42:01]

Patchset 2 adds PDF files/tests with hidden AP annotations.

[tonikitoo, 2016-08-15 13:43:03]

Description was changed from

==========
Add 'hidden' annotations tests pdfium/annots/

CL adds "hidden annotation" variants to the existing
annotation tests in

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup2_hidden.pdf
- new_textmarkup4_hidden.pdf
- new_textmarkup5_hidden.pdf
- new_textmarkup7_hidden.pdf
- new_textmarkup8_hidden.pdf

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

to

==========
Add 'hidden' annotations tests

CL adds "hidden annotation" variants to the existing
annotation tests in

(pdfium/annots/):
- annotation_circle_hidden.pdf
- annotation_ellipse_hidden.pdf
- annotation_highlight_hidden.pdf
- annotation_ink_hidden.pdf
- annotation_square_hidden.pdf
- annotation_squiggly_hidden.pdf
- annotation_strikeout_hidden.pdf
- annotation_underline_hidden.pdf

(fx/mulobj/new/text_markup/):
- new_textmarkup1_hidden.pdf
- new_textmarkup2_hidden.pdf
- new_textmarkup4_hidden.pdf
- new_textmarkup5_hidden.pdf
- new_textmarkup7_hidden.pdf
- new_textmarkup8_hidden.pdf

This is how each pdf test being added was generated:

1) uncompressed the PDF file with qpdf:

$ qpdf --stream-data=uncompress {pdf_file}.pdf {pdf_file}_hidden.pdf

2) editted {pdf_file}_hidden.pdf source manually changing
its "/F 4" entry to "/F 2". 

3) compress {pdf_file}_hidden.pdf back with qpdf:

$ qpdf --stream-data=compress {pdf_file}_hidden.pdf {pdf_file}_hidden.pdf

Also, note that each PDF file added is accompanied of its own 
*correct* expected result (png).
The behavior fix on PDFium side is happening in [1].

[1] https://codereview.chromium.org/2239853002
==========

[Tom Sepez, 2016-08-15 16:48:24]

On 2016/08/13 15:42:01, tonikitoo1 wrote:
> Patchset 2 adds PDF files/tests with hidden AP annotations.

LGTM.  Note that the CL that uses these files will be part of the pdfium (not
pdfium_test) repository, and will update /DEPS to set 'pdfium_tests_revision' to
the version generated by this checkin.  Typically, doing so will cause some bots
to go red on other platforms as tests fail due to pixel to pixel diffs.  Hence
the testing/SUPPRESSIONS file gets update in parallel.

[tonikitoo, 2016-08-15 17:49:38]

On 2016/08/15 16:48:24, Tom Sepez wrote:
> On 2016/08/13 15:42:01, tonikitoo1 wrote:
> > Patchset 2 adds PDF files/tests with hidden AP annotations.
> 
> LGTM.  Note that the CL that uses these files will be part of the pdfium (not
> pdfium_test) repository, and will update /DEPS to set 'pdfium_tests_revision'
to
> the version generated by this checkin.  Typically, doing so will cause some
bots
> to go red on other platforms as tests fail due to pixel to pixel diffs.  Hence
> the testing/SUPPRESSIONS file gets update in parallel.

Thanks. I believe a good coordinated way going forward here would be:

1) wait for the pdfium CL [1] to get LGTM'ed
2) flag the CQ+ bit here to get it merged
3) Get the Git SHA of this CL in the pdfium_test repository
4) update [1] to roll pdfium_tests DEPs, and CQ+ it.

Is this the flow you guys do?

[1] https://codereview.chromium.org/2239853002/

[jaepark, 2016-08-15 18:33:56]

On 2016/08/15 17:49:38, tonikitoo1 wrote:
> Thanks. I believe a good coordinated way going forward here would be:
> 
> 1) wait for the pdfium CL [1] to get LGTM'ed
> 2) flag the CQ+ bit here to get it merged
> 3) Get the Git SHA of this CL in the pdfium_test repository
> 4) update [1] to roll pdfium_tests DEPs, and CQ+ it.
> 
> Is this the flow you guys do?
> 
> [1] https://codereview.chromium.org/2239853002/

Yes, that is the flow we use.
Make sure you pass all the tests after rolling pdfium_tests DEPS in [1].

[Lei Zhang, 2016-08-16 02:09:50]

jaepark will land this in https://codereview.chromium.org/2250543003/

[tonikitoo, 2016-08-16 15:00:39]

On 2016/08/16 02:09:50, Lei Zhang wrote:
> jaepark will land this in https://codereview.chromium.org/2250543003/

Ok closing here.