core/fpdfapi/fpdf_parser/cpdf_string.cpp - Issue 2250533002: Fix stack overflow in object Clone() functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_string.cpp

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_string.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_string.cpp b/core/fpdfapi/fpdf_parser/cpdf_string.cpp

index 4b92596242489bfab39f15a9d80122e1c21cb979..b18d48434749498f15a10dafb6feb060f91017f3 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_string.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_string.cpp

@@ -23,7 +23,7 @@ CPDF_Object::Type CPDF_String::GetType() const {

return STRING;

}

-CPDF_Object* CPDF_String::Clone(FX_BOOL bDirect) const {

+CPDF_Object* CPDF_String::Clone() const {

return new CPDF_String(m_String, m_bHex);

}