Fix stack overflow in object Clone() functions

core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

Index: core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
index 29846366d9173dfe969159196dd0012b25d8fd86..f7a4933392a4a712ff5613d7b18f85bb554ad5ea 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
@@ -8,6 +8,7 @@
 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_DICTIONARY_H_
 
 #include <map>
+#include <set>
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
 #include "core/fxcrt/include/fx_coordinates.h"
@@ -24,7 +25,7 @@ class CPDF_Dictionary : public CPDF_Object {
 
   // CPDF_Object.
   Type GetType() const override;
-  CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;
+  CPDF_Object* Clone() const override;
   CPDF_Dictionary* GetDict() const override;
   bool IsDictionary() const override;
   CPDF_Dictionary* AsDictionary() override;
@@ -84,6 +85,9 @@ class CPDF_Dictionary : public CPDF_Object {
 
  protected:
   ~CPDF_Dictionary() override;

[Lei Zhang, 2016/08/19 16:21:09]

Ditto, add a separator line.

[Wei Li, 2016/08/19 18:14:57]

Done.

+  CPDF_Object* CloneNonCyclic(
+      bool bDirect,
+      std::set<const CPDF_Object*>* visited) const override;
 
   std::map<CFX_ByteString, CPDF_Object*> m_Map;
 };