Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2250473007: Move UseNonBlockingIO from a windows-only method (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move UseNonBlockingIO from a windows-only method on UdpClientSocket and UdpServerSocket to DatagramSocket. BUG=600045 Committed: https://crrev.com/a7c6592902e80d2efb2d9f3877b8bf48756289b2 Cr-Commit-Position: refs/heads/master@{#412816}

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : net_fuzzer_test_support #

Patch Set 4 : socket_host_udp_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M net/dns/address_sorter_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/mock_mdns_socket_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M net/socket/socket_test_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/udp/datagram_socket.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/udp/fuzzed_datagram_client_socket.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/udp/fuzzed_datagram_client_socket.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/udp/udp_client_socket.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/udp/udp_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/udp/udp_server_socket.h View 2 chunks +1 line, -6 lines 0 comments Download
M net/udp/udp_server_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/udp/udp_socket_perftest.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
M net/udp/udp_socket_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
Ryan Hamilton
4 years, 4 months ago (2016-08-16 22:50:04 UTC) #4
ramant (doing other things)
lgtm
4 years, 4 months ago (2016-08-16 23:40:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250473007/20001
4 years, 4 months ago (2016-08-17 20:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250473007/20001
4 years, 4 months ago (2016-08-17 20:30:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/262925)
4 years, 4 months ago (2016-08-17 20:46:13 UTC) #12
Ryan Hamilton
sergeyu: socket_host_udp_unittest.cc
4 years, 4 months ago (2016-08-17 22:27:57 UTC) #19
Sergey Ulanov
lgtm
4 years, 4 months ago (2016-08-18 05:43:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250473007/60001
4 years, 4 months ago (2016-08-18 13:45:07 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-18 13:49:24 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 13:51:23 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a7c6592902e80d2efb2d9f3877b8bf48756289b2
Cr-Commit-Position: refs/heads/master@{#412816}

Powered by Google App Engine
This is Rietveld 408576698